src/hg/hgTracks/hgTracks.c 1.1565

1.1565 2009/05/12 00:00:37 angie
Quick fix for an interaction bug before the code release -- I hope a cleaner fix can be implemented afterwards. groupTracks() removes cart vars that are redundant with trackDb settings, which I think is good for reducing cart bloat. Unfortunately, something upstream of trackFromTrackDb, and also trackFromTrackDb itself, overwrite tdb->priority with the cart value, causing false detection of redundancy with trackDb here.

Index: src/hg/hgTracks/hgTracks.c
===================================================================
RCS file: /projects/compbio/cvsroot/kent/src/hg/hgTracks/hgTracks.c,v
retrieving revision 1.1564
retrieving revision 1.1565
diff -b -B -U 4 -r1.1564 -r1.1565
--- src/hg/hgTracks/hgTracks.c	8 May 2009 16:49:17 -0000	1.1564
+++ src/hg/hgTracks/hgTracks.c	12 May 2009 00:00:37 -0000	1.1565
@@ -3250,10 +3250,12 @@
         safef(cartVar, sizeof(cartVar), "%s.priority",track->mapName);
         float priority = (float)cartUsualDouble(cart, cartVar,
                                                     track->defaultPriority);
         /* remove cart variables that are the same as the trackDb settings */
+/*  UGLY - add me back when tdb->priority is no longer pre-clobbered by cart var value
         if (priority == track->defaultPriority)
             cartRemove(cart, cartVar);
+*/
         track->priority = priority;
         }
 
     /* assign group object to track */