src/hg/lib/hui.c 1.238
1.238 2009/09/23 18:42:20 angie
Fixed compiler warnings from gcc 4.3.3, mostly about system calls whose return values weren't checked and non-literal format strings with no args.
Index: src/hg/lib/hui.c
===================================================================
RCS file: /projects/compbio/cvsroot/kent/src/hg/lib/hui.c,v
retrieving revision 1.237
retrieving revision 1.238
diff -b -B -U 4 -r1.237 -r1.238
--- src/hg/lib/hui.c 18 Sep 2009 20:05:09 -0000 1.237
+++ src/hg/lib/hui.c 23 Sep 2009 18:42:20 -0000 1.238
@@ -2552,9 +2552,9 @@
if(slNameInList(filterBy->slChoices,"All"))
return NULL;
struct dyString *dyClause = newDyString(256);
-dyStringPrintf(dyClause, filterBy->column);
+dyStringAppend(dyClause, filterBy->column);
if(count == 1)
dyStringPrintf(dyClause, " = ");
else
dyStringPrintf(dyClause, " in (");
@@ -2566,9 +2566,9 @@
if(notFirst)
dyStringPrintf(dyClause, ",");
notFirst = TRUE;
if(filterBy->useIndex)
- dyStringPrintf(dyClause, slChoice->name);
+ dyStringAppend(dyClause, slChoice->name);
else
dyStringPrintf(dyClause, "\"%s\"",slChoice->name);
}
if(dyStringLen(dyClause) == 0)
@@ -2606,9 +2606,9 @@
if(clause != NULL)
{
if(*and)
dyStringPrintf(extraWhere, " AND ");
- dyStringPrintf(extraWhere, clause);
+ dyStringAppend(extraWhere, clause);
freeMem(clause);
*and = TRUE;
}
}
@@ -2629,9 +2629,9 @@
if(clause != NULL)
{
if(notFirst)
dyStringPrintf(dyClause, " AND ");
- dyStringPrintf(dyClause, clause);
+ dyStringAppend(dyClause, clause);
freeMem(clause);
notFirst = TRUE;
}
}
@@ -5122,9 +5122,9 @@
}
alreadySet = cartUsualBoolean(cart, objName, FALSE);
puts("<TD>");
struct dyString *dyJS = newDyString(100);
- dyStringPrintf(dyJS, javascript);
+ dyStringAppend(dyJS, javascript);
dyStringPrintf(dyJS, " class=\"matrixCB");
if(dimensionX)
dyStringPrintf(dyJS, " %s",dimensionX->names[ixX]);
if(dimensionY)
@@ -5162,9 +5162,9 @@
safef(objName, sizeof(objName), "mat_%s_dimZ_cb",dimensionZ->names[ixZ]);
safef(javascript, sizeof(javascript), "onclick='matSetSubtrackCheckBoxes(this.checked,\"%s\");'",dimensionZ->names[ixZ]);
alreadySet = cartUsualBoolean(cart, objName, FALSE);
struct dyString *dyJS = newDyString(100);
- dyStringPrintf(dyJS, javascript);
+ dyStringAppend(dyJS, javascript);
dyStringPrintf(dyJS, " class=\"matrixCB dimZ %s\"",dimensionZ->names[ixZ]);
cgiMakeCheckBoxJS(objName,alreadySet,dyStringCannibalize(&dyJS));
printf("%s",labelWithVocabLink(parentTdb,tdbsZ[ixZ],dimensionZ->tag,dimensionZ->values[ixZ]));
puts("</TH>");