src/lib/htmlPage.c 1.38
1.38 2009/09/23 18:42:28 angie
Fixed compiler warnings from gcc 4.3.3, mostly about system calls whose return values weren't checked and non-literal format strings with no args.
Index: src/lib/htmlPage.c
===================================================================
RCS file: /projects/compbio/cvsroot/kent/src/lib/htmlPage.c,v
retrieving revision 1.37
retrieving revision 1.38
diff -b -B -U 4 -r1.37 -r1.38
--- src/lib/htmlPage.c 9 Jul 2009 19:35:23 -0000 1.37
+++ src/lib/htmlPage.c 23 Sep 2009 18:42:28 -0000 1.38
@@ -900,9 +900,9 @@
cookieOutput(dyHeader, cookies);
dyStringAppend(dyHeader, "\r\n");
sd = netOpenHttpExt(url, "GET", FALSE);
-write(sd, dyHeader->string, dyHeader->stringSize);
+mustWriteFd(sd, dyHeader->string, dyHeader->stringSize);
dyText = netSlurpFile(sd);
close(sd);
dyStringFree(&dyHeader);
return dyStringCannibalize(&dyText);
@@ -944,9 +944,9 @@
if (errCatchStart(errCatch))
page = htmlPageForwarded(url, cookies);
errCatchEnd(errCatch);
if (errCatch->gotError)
- warn(errCatch->message->string);
+ warn("%s", errCatch->message->string);
errCatchFree(&errCatch);
return page;
}
@@ -1377,9 +1377,9 @@
dyStringAppend(dyUrl, cgiVars);
verbose(3, "GET %s\n", dyUrl->string);
sd = netOpenHttpExt(dyUrl->string, form->method, FALSE);
dyStringAppend(dyHeader, "\r\n");
- write(sd, dyHeader->string, dyHeader->stringSize);
+ mustWriteFd(sd, dyHeader->string, dyHeader->stringSize);
}
else if (sameWord(form->method, "POST"))
{
cgiVars = htmlFormCgiVars(origPage, form, buttonName, buttonVal, dyHeader);
@@ -1387,10 +1387,10 @@
verbose(3, "POST %s\n", dyUrl->string);
sd = netOpenHttpExt(dyUrl->string, form->method, FALSE);
dyStringPrintf(dyHeader, "Content-length: %d\r\n", contentLength);
dyStringAppend(dyHeader, "\r\n");
- write(sd, dyHeader->string, dyHeader->stringSize);
- write(sd, cgiVars, contentLength);
+ mustWriteFd(sd, dyHeader->string, dyHeader->stringSize);
+ mustWriteFd(sd, cgiVars, contentLength);
}
dyText = netSlurpFile(sd);
close(sd);
newPage = htmlPageParse(url, dyStringCannibalize(&dyText));