src/hg/hgTracks/config.c 1.86
1.86 2009/11/12 20:50:54 tdreszer
Bob does not want no double negatives so I disabled the disable and instead enabled 'Enable advanced javascript features'
Index: src/hg/hgTracks/config.c
===================================================================
RCS file: /projects/compbio/cvsroot/kent/src/hg/hgTracks/config.c,v
retrieving revision 1.85
retrieving revision 1.86
diff -b -B -U 4 -r1.85 -r1.86
--- src/hg/hgTracks/config.c 11 Nov 2009 21:13:13 -0000 1.85
+++ src/hg/hgTracks/config.c 12 Nov 2009 20:50:54 -0000 1.86
@@ -402,11 +402,11 @@
hPrintf("Enable track re-ordering");
hPrintf("</TD></TR>\n");
hPrintf("<TR><TD>");
-hCheckBox("disableAdvancedJavascript", !advancedJavascriptFeaturesEnabled(cart));
+hCheckBox("enableAdvancedJavascript", advancedJavascriptFeaturesEnabled(cart));
hPrintf("</TD><TD>");
-hPrintf("Disable advanced javascript features");
+hPrintf("Enable advanced javascript features");
hPrintf("</TD></TR>\n");
hTableEnd();
@@ -444,9 +444,9 @@
boolean advancedJavascriptFeaturesEnabled(struct cart *cart)
// Returns TRUE if advanced javascript features are currently enabled
{
char *ua = cgiUserAgent();
-boolean defaultVal = FALSE;
+boolean defaultVal = TRUE;
// dragZooming was broken in version 530.4 of AppleWebKit browsers (used by Safari, Chrome and some other browsers).
// This was explicitly fixed by the WebKit team in version 531.0.1 (see http://trac.webkit.org/changeset/45143).
// The AppleWebKit version provided by the browser in user agent doesn't always include the minor version number, so to
@@ -459,9 +459,9 @@
if(ptr != NULL)
{
int version = 0;
sscanf(ptr + strlen(needle), "%d", &version);
- defaultVal = (version == 530);
+ defaultVal = (version != 530);
}
}
-return (cartUsualBoolean(cart, "disableAdvancedJavascript", defaultVal) == FALSE); // Sorry about the double negative!
+return cartUsualBoolean(cart, "enableAdvancedJavascript", defaultVal);
}