src/hg/utils/gff3ToGenePred/gff3ToGenePred.c 1.4

1.4 2010/03/20 15:43:18 markd
fixed various issues with error reporting
Index: src/hg/utils/gff3ToGenePred/gff3ToGenePred.c
===================================================================
RCS file: /projects/compbio/cvsroot/kent/src/hg/utils/gff3ToGenePred/gff3ToGenePred.c,v
retrieving revision 1.3
retrieving revision 1.4
diff -b -B -U 4 -r1.3 -r1.4
--- src/hg/utils/gff3ToGenePred/gff3ToGenePred.c	19 Mar 2010 06:04:18 -0000	1.3
+++ src/hg/utils/gff3ToGenePred/gff3ToGenePred.c	20 Mar 2010 15:43:18 -0000	1.4
@@ -41,8 +41,9 @@
 
 static void cnvError(char *format, ...)
 /* print a convert error */
 {
+fputs("Error: ", stderr);
 va_list args;
 va_start(args, format);
 vfprintf(stderr, format, args);
 va_end(args);
@@ -212,9 +213,9 @@
 // output before checking so it can be examined
 genePredTabOut(gp, gpFh);
 if (genePredCheck("GFF3 convert to genePred", stderr, -1, gp) != 0)
     {
-    cnvError("conversion failed");
+    cnvError("discarding invalid genePred created for: %s", gp->name);
     genePredFree(&gp);
     return; // error
     }
 
@@ -233,9 +234,9 @@
     {
     if (sameString(child->ann->type, gff3FeatMRna) && !isProcessed(processed, child->ann))
         {
         processMRna(gpFh, gene, child->ann, processed);
-        if (convertErrCnt > maxConvertErrs)
+        if (convertErrCnt >= maxConvertErrs)
             break;
         }
     }
 }
@@ -263,9 +264,9 @@
     {
     if (!isProcessed(processed, root->ann))
         {
         processRoot(gpFh, root->ann, processed);
-        if (convertErrCnt > maxConvertErrs)
+        if (convertErrCnt >= maxConvertErrs)
             break;
         }
     }
 carefulClose(&gpFh);