4a780c39a90e673bcba486da2dc4f9a5af1fd7f6 tdreszer Mon May 16 13:33:16 2011 -0700 Greg recommended this simplification in code review. diff --git src/hg/hgTrackUi/hgTrackUi.c src/hg/hgTrackUi/hgTrackUi.c index bc70b0e..d27c930 100644 --- src/hg/hgTrackUi/hgTrackUi.c +++ src/hg/hgTrackUi/hgTrackUi.c @@ -161,31 +161,31 @@ { gTdb = hashFindVal(trackHash, gt->name); if (gTdb && sameString(gTdb->grp, "genes")) { // We are going to overwrite gTdb's next pointer and possibly its priority, // so make a shallow copy: gTdb = CloneVar(gTdb); if (gTdb->parent) gTdb->priority = (gTdb->parent->priority + gTdb->priority/1000); slAddHead(&geneTdbList, gTdb); } } slSort(&geneTdbList, trackDbCmp); jsBeginCollapsibleSection(cart, tdb->track, "geneTracks", "Use Gene Tracks for Functional Annotation", FALSE); - printf("<BR><B>On details page, show function and coding differences relative to: </B> "); + printf("<BR><B>On details page, show function and coding differences relative to: </B>\n"); char cartVar[256]; safef(cartVar, sizeof(cartVar), "%s_geneTrack", tdb->track); jsMakeCheckboxGroupSetClearButton(cartVar, TRUE); jsMakeCheckboxGroupSetClearButton(cartVar, FALSE); struct slName *selectedGeneTracks = cartOptionalSlNameList(cart, cartVar); if (!cartListVarExists(cart, cartVar)) { char *defaultGeneTracks = trackDbSetting(tdb, "defaultGeneTracks"); if (isNotEmpty(defaultGeneTracks)) selectedGeneTracks = slNameListFromComma(defaultGeneTracks); } int numCols = 4, i; int menuSize = slCount(geneTdbList); char **values = needMem(menuSize*sizeof(char *)); char **labels = needMem(menuSize*sizeof(char *)); @@ -2858,31 +2858,31 @@ printf("<B>Data version:</B> %s\n", version); } /* Print lift information from trackDb, if any */ trackDbPrintOrigAssembly(tdb, database); printUpdateTime(database, tdb, NULL); } if (tdb->html != NULL && tdb->html[0] != 0) { char *browserVersion; if (btIE == cgiClientBrowser(&browserVersion, NULL, NULL) && *browserVersion < '8') htmlHorizontalLine(); else // Move line down, since <H2>Description (in ->html) is proceded by too much space - printf("<span style='position:relative; top:1em;'><HR ALIGN='bottom'></span>"); + printf("<HR ALIGN='bottom' style='position:relative; top:1em;'>"); printf("<table class='windowSize'><tr valign='top'><td rowspan=2>"); puts("<A NAME='TRACK_HTML'></A>"); // include anchor for Description link // Add pennantIcon printPennantIconNote(tdb); puts(tdb->html); printf("</td><td nowrap>"); cgiDown(0.7); // positions top link below line makeTopLink(tdb); printf(" </td></tr><tr valign='bottom'><td nowrap>"); makeTopLink(tdb); printf(" </td></tr></table>"); }