566d49eda32eeed2e5877079020760c8eb82a575 larrym Fri Aug 5 12:30:29 2011 -0700 update safari related comments diff --git src/hg/js/hgTracks.js src/hg/js/hgTracks.js index d8dabba..26c16e0 100644 --- src/hg/js/hgTracks.js +++ src/hg/js/hgTracks.js @@ -241,52 +241,50 @@ return true; } $(window).load(function () { jQuery.each(jQuery.browser, function(i, val) { if(val) { browser = i; } }); // jQuery load function with stuff to support drag selection in track img if(browser == "safari") { if(navigator.userAgent.indexOf("Chrome") != -1) { // Handle the fact that (as of 1.3.1), jQuery.browser reports "safari" when the browser is in fact Chrome. browser = "chrome"; } else { - // Turn off mapIsUpdateable for safari < version 5.1 because it has a bug which causes updates of map to be ignored. + // Safari has the following bug: if we update the hgTracks map dynamically, the browser ignores the changes (even + // though if you look in the DOM the changes are there). So we have to do a full form submission when the + // user changes visibility settings or track configuration. + // As of 5.0.4 (7533.20.27) this is problem still exists in safari. + // As of 5.1 (7534.50) this problem appears to have been fixed - unfortunately, logs for 7/2011 show vast majority of safari users + // are pre-5.1 (5.0.5 is by far the most common). + // + // Early versions of Chrome had this problem too, but this problem went away as of Chrome 5.0.335.1 (or possibly earlier). mapIsUpdateable = false; var reg = new RegExp("Version\/(\[0-9]+\.\[0-9]+) Safari"); var a = reg.exec(navigator.userAgent); if(a && a[1]) { var version = a[1] * 1; if(version >= 5.1) { mapIsUpdateable = true; } } } } - // Safari has the following bug: if we update the hgTracks map dynamically, the browser ignores the changes (even - // though if you look in the DOM the changes are there); so we have to do a full form submission when the - // user changes visibility settings or track configuration. - // As of 5.0.4 (7533.20.27) this is problem still exists in safari. - // As of 5.1 (7534.50) this problem appears to have been fixed - unfortunately, logs for 7/2011 show vast majority of safari users - // are pre-5.1 (5.0.5 is by far the most common). - // - // Chrome used to have this problem too, but this problem seems to have gone away as of - // Chrome 5.0.335.1 (or possibly earlier). inPlaceUpdate = hgTracks.inPlaceUpdate && mapIsUpdateable; loadImgAreaSelect(true); if($('#hgTrackUiDialog')) $('#hgTrackUiDialog').hide(); // Don't load contextMenu if jquery.contextmenu.js hasn't been loaded if(trackImg && jQuery.fn.contextMenu) { $('#hgTrackUiDialog').hide(); if(imageV2) { $("map[name!=ideoMap]").each( function(t) { parseMap($(this,false));}); } else { // XXXX still under debate whether we have to remove the map parseMap($('#map'),true); $('#map').empty(); }