de502f76b6a9d28e894267a2a70d12be228f8bf0 angie Tue Aug 30 23:43:00 2011 -0700 Use safecpy instead of safef when there is no formatting to do, so we avoidstrict compiler warnings about variable used as format string. diff --git src/hg/lib/hubConnect.c src/hg/lib/hubConnect.c index ce1798a..b6ea4d3 100644 --- src/hg/lib/hubConnect.c +++ src/hg/lib/hubConnect.c @@ -555,31 +555,31 @@ cartRemove(cart, buffer); } void hubSetErrorMessage(char *errorMessage, unsigned id) /* set the error message in the hubStatus table */ { struct sqlConnection *conn = hConnectCentral(); char query[4096]; if (errorMessage != NULL) { // make sure there is no newline at the end. This should be unneccesary // but there are many, many places where newlines are added in calls // to warn and errAbort char buffer[4096]; - safef(buffer, sizeof buffer, errorMessage); + safecpy(buffer, sizeof buffer, errorMessage); while (lastChar(buffer) == '\n') buffer[strlen(buffer) - 1] = '\0'; safef(query, sizeof(query), "update %s set errorMessage=\"%s\", lastNotOkTime=now() where id=%d", hubStatusTableName, buffer, id); } else { safef(query, sizeof(query), "update %s set errorMessage=\"\", lastOkTime=now() where id=%d", hubStatusTableName, id); } sqlUpdate(conn, query); hDisconnectCentral(&conn); }