3b7879514037e7aecfbc8a4a0cdd563f1629ca80
kent
  Fri May 11 07:31:07 2012 -0700
Adding comment to some bad HTML generation that is near ubiquitous - in cartWebStart to remind us to test what happens when we take it out.
diff --git src/hg/lib/cart.c src/hg/lib/cart.c
index 6ef9098..ff92c7a 100644
--- src/hg/lib/cart.c
+++ src/hg/lib/cart.c
@@ -1473,30 +1473,36 @@
 webStartWrapper(cart, db, format, args, FALSE, FALSE);
 inWeb = TRUE;
 }
 
 void cartWebStart(struct cart *cart, char *db, char *format, ...)
 /* Print out pretty wrapper around things when working
  * from cart. */
 {
 va_list args;
 va_start(args, format);
 cartVaWebStart(cart, db, format, args);
 va_end(args);
 jsIncludeFile("jquery.js", NULL);
 jsIncludeFile("utils.js", NULL);
 jsIncludeFile("ajax.js", NULL);
+// WTF - variable outside of a form on almost every page we make below?
+// Tim put this in.  Talking with him it sounds like some pages might actually
+// depend on it.  Not removing it until we have a chance to test.  Best fix
+// might be to add it to cartSaveSession, though this would then no longer be
+// well named, and not all things have 'db.'  Arrr.  Probably best to remove
+// and test a bunch.
 cgiMakeHiddenVar("db", db);
 }
 
 void cartWebEnd()
 /* Write out HTML footer and get rid or error handler. */
 {
 webEnd();
 popWarnHandler();
 }
 
 void cartFooter(void)
 /* Write out HTML footer, possibly with googleAnalytics too */
 {
 #ifndef GBROWSE
 googleAnalytics();	/* can't do this in htmlEnd	*/