a8f93bb9c0961e8e3ac25a0168ad2d2eb6b66fad kent Wed Apr 25 23:30:45 2012 -0700 Fixing missing c=chromName in a lot of links. A bug Tim put in 2009 from what I can tell that manifests with an empty cart on IE. diff --git src/hg/hgTracks/simpleTracks.c src/hg/hgTracks/simpleTracks.c index f19dc56..58e8c43 100644 --- src/hg/hgTracks/simpleTracks.c +++ src/hg/hgTracks/simpleTracks.c @@ -732,58 +732,58 @@ { char *encodedItem = cgiEncode(item); char *encodedTrack = cgiEncode(track); if(theImgBox && curImgTrack) { char link[512]; if (directUrl) { safef(link,sizeof(link),directUrl, item, chromName, start, end, encodedTrack, database); if (withHgsid) safef(link+strlen(link),sizeof(link)-strlen(link),"&%s", cartSidUrlString(cart)); } else { - safef(link,sizeof(link),"%s&o=%d&t=%d&g=%s&i=%s", - hgcNameAndSettings(), start, end, encodedTrack, encodedItem); // NOTE: chopped out winStart/winEnd + safef(link,sizeof(link),"%s&c=%s&o=%d&t=%d&g=%s&i=%s", + hgcNameAndSettings(), chromName, start, end, encodedTrack, encodedItem); // NOTE: chopped out winStart/winEnd } if (extra != NULL) safef(link+strlen(link),sizeof(link)-strlen(link),"&%s", extra); // Add map item to currnent map (TODO: pass in map) #ifdef IMAGEv2_SHORT_MAPITEMS if(!revCmplDisp && x < insideX && xEnd > insideX) // Why does insideX=118 in reverse complement?? x = insideX; else if (revCmplDisp && x < insideWidth && xEnd > insideWidth) xEnd = insideWidth - 1; #endif//def IMAGEv2_SHORT_MAPITEMS imgTrackAddMapItem(curImgTrack,link,(char *)(statusLine!=NULL?statusLine:NULL),x, y, xEnd, yEnd, track); } else { hPrintf("<AREA SHAPE=RECT COORDS=\"%d,%d,%d,%d\" ", x, y, xEnd, yEnd); if (directUrl) { hPrintf("HREF=\""); hPrintf(directUrl, item, chromName, start, end, encodedTrack, database); if (withHgsid) hPrintf("&%s", cartSidUrlString(cart)); } else { - hPrintf("HREF=\"%s&o=%d&t=%d&g=%s&i=%s&c=%s&l=%d&r=%d&db=%s&pix=%d", - hgcNameAndSettings(), start, end, encodedTrack, encodedItem, + hPrintf("HREF=\"%s&c=%s&o=%d&t=%d&g=%s&i=%s&c=%s&l=%d&r=%d&db=%s&pix=%d", + hgcNameAndSettings(), chromName, start, end, encodedTrack, encodedItem, chromName, winStart, winEnd, database, tl.picWidth); } if (extra != NULL) hPrintf("&%s", extra); hPrintf("\" "); if (statusLine != NULL) mapStatusMessage("%s", statusLine); hPrintf("%s>\n", dyStringContents(id)); } freeMem(encodedItem); freeMem(encodedTrack); } freeDyString(&id); }