19149484af1ba906e32a25e1cd4281522bbf45ca max Tue May 1 11:53:34 2012 -0700 code review kate changes: whitespace corrections and changes of comments diff --git src/hg/hgc/pubs.c src/hg/hgc/pubs.c index 3616e83..6b9425c 100644 --- src/hg/hgc/pubs.c +++ src/hg/hgc/pubs.c @@ -29,36 +29,39 @@ "results", "discussion", "conclusions", "ack", "refs", "unknown" }; // // whether a checkbox is checked by default, have to correspond to pubsSecNames static int pubsSecChecked[] ={ 1, 1, 1, 1, 1, 1, 1, 0, 0, 1 }; static char* pubsSequenceTable; -/* ------ START based on QA's suggestions, functions to replace old HTML tables */ - +/* ------ functions to replace HTML4 tables with HTML5 constructs */ +/* Web wrappers incorporating tag, id, and class HTML attributes, to support + * styling and test */ /* Suffix -S for "function accepts style parameter" * Suffix -C for "function accepts class parameter" * Suffix -CI for "function accepts class and id parameter" + * + * Some functions are commented out because they are not yet used. */ static void web2Start(char* tag) { printf("<%s>\n", tag); } static void web2End(char* tag) { printf("</%s>\n", tag); } static void web2StartS(char* style, char* tag) { printf("<%s style=\"%s\">\n", tag, style); @@ -131,53 +134,53 @@ printf("%s</th>", label); } static void web2PrintCellF(char* format, ...) /* print a td with format */ { va_list args; va_start(args, format); web2StartCell(); vprintf(format, args); web2EndCell(); va_end(args); } - - static void web2StartSection(char* id, char* format, ...) /* create a new section on the web page */ { va_list args; va_start(args, format); puts("<!-- START NEW SECTION -->\n"); web2StartDivCI("section", id); web2StartDivC("subheadingBar windowSize"); vprintf(format, args); web2EndDiv("subheadingBar"); va_end(args); } static void web2EndSection() /* end section */ { web2EndDiv("section"); } -/* ------ END based on QA's suggestions, functions to replace old HTML tables */ +/* ------ */ + + static char* mangleUrl(char* url) /* add publisher specific parameters to url and return new url*/ { if (!stringIn("sciencedirect.com", url)) return url; // cgi param to add the "UCSC matches" sciverse application to elsevier's sciencedirect char* sdAddParam = "?svAppaddApp=298535"; char* longUrl = catTwoStrings(url, sdAddParam); char* newUrl = replaceChars(longUrl, "article", "svapps"); return newUrl; } static void printFilterLink(char* pslTrack, char* articleId, char* articleTable)