080a160c7b9595d516c9c70e83689a09b60839d0 galt Mon Jun 3 12:16:53 2013 -0700 fix SQL Injection diff --git src/hg/hgLogin/gbMembers.h src/hg/hgLogin/gbMembers.h index f706e96..c3816b1 100644 --- src/hg/hgLogin/gbMembers.h +++ src/hg/hgLogin/gbMembers.h @@ -31,42 +31,31 @@ /* Load a row from gbMembers table into ret. The contents of ret will * be replaced at the next call to this function. */ struct gbMembers *gbMembersLoadByQuery(struct sqlConnection *conn, char *query); /* Load all gbMembers from table that satisfy the query given. * Where query is of the form 'select * from example where something=something' * or 'select example.* from example, anotherTable where example.something = * anotherTable.something'. * Dispose of this with gbMembersFreeList(). */ void gbMembersSaveToDb(struct sqlConnection *conn, struct gbMembers *el, char *tableName, int updateSize); /* Save gbMembers as a row to the table specified by tableName. * As blob fields may be arbitrary size updateSize specifies the approx size * of a string that would contain the entire query. Arrays of native types are * converted to comma separated strings and loaded as such, User defined types are - * inserted as NULL. Note that strings must be escaped to allow insertion into the database. - * For example "autosql's features include" --> "autosql\'s features include" - * If worried about this use gbMembersSaveToDbEscaped() */ - -void gbMembersSaveToDbEscaped(struct sqlConnection *conn, struct gbMembers *el, char *tableName, int updateSize); -/* Save gbMembers as a row to the table specified by tableName. - * As blob fields may be arbitrary size updateSize specifies the approx size. - * of a string that would contain the entire query. Automatically - * escapes all simple strings (not arrays of string) but may be slower than gbMembersSaveToDb(). - * For example automatically copies and converts: - * "autosql's features include" --> "autosql\'s features include" - * before inserting into database. */ + * inserted as NULL. Strings are automatically escaped to allow insertion into the database. */ struct gbMembers *gbMembersLoad(char **row); /* Load a gbMembers from row fetched with select * from gbMembers * from database. Dispose of this with gbMembersFree(). */ struct gbMembers *gbMembersLoadAll(char *fileName); /* Load all gbMembers from whitespace-separated file. * Dispose of this with gbMembersFreeList(). */ struct gbMembers *gbMembersLoadAllByChar(char *fileName, char chopper); /* Load all gbMembers from chopper separated file. * Dispose of this with gbMembersFreeList(). */ #define gbMembersLoadAllByTab(a) gbMembersLoadAllByChar(a, '\t'); /* Load all gbMembers from tab separated file.