080a160c7b9595d516c9c70e83689a09b60839d0 galt Mon Jun 3 12:16:53 2013 -0700 fix SQL Injection diff --git src/hg/inc/taxonName.h src/hg/inc/taxonName.h index d6d1ca8..1ad744b 100644 --- src/hg/inc/taxonName.h +++ src/hg/inc/taxonName.h @@ -40,42 +40,31 @@ /* Load all taxonName from tab separated file. * Dispose of this with taxonNameFreeList(). */ struct taxonName *taxonNameLoadByQuery(struct sqlConnection *conn, char *query); /* Load all taxonName from table that satisfy the query given. * Where query is of the form 'select * from example where something=something' * or 'select example.* from example, anotherTable where example.something = * anotherTable.something'. * Dispose of this with taxonNameFreeList(). */ void taxonNameSaveToDb(struct sqlConnection *conn, struct taxonName *el, char *tableName, int updateSize); /* Save taxonName as a row to the table specified by tableName. * As blob fields may be arbitrary size updateSize specifies the approx size * of a string that would contain the entire query. Arrays of native types are * converted to comma separated strings and loaded as such, User defined types are - * inserted as NULL. Note that strings must be escaped to allow insertion into the database. - * For example "autosql's features include" --> "autosql\'s features include" - * If worried about this use taxonNameSaveToDbEscaped() */ - -void taxonNameSaveToDbEscaped(struct sqlConnection *conn, struct taxonName *el, char *tableName, int updateSize); -/* Save taxonName as a row to the table specified by tableName. - * As blob fields may be arbitrary size updateSize specifies the approx size. - * of a string that would contain the entire query. Automatically - * escapes all simple strings (not arrays of string) but may be slower than taxonNameSaveToDb(). - * For example automatically copies and converts: - * "autosql's features include" --> "autosql\'s features include" - * before inserting into database. */ + * inserted as NULL. Strings are automatically escaped to allow insertion into the database. */ struct taxonName *taxonNameCommaIn(char **pS, struct taxonName *ret); /* Create a taxonName out of a comma separated string. * This will fill in ret if non-null, otherwise will * return a new taxonName */ void taxonNameFree(struct taxonName **pEl); /* Free a single dynamically allocated taxonName such as created * with taxonNameLoad(). */ void taxonNameFreeList(struct taxonName **pList); /* Free a list of dynamically allocated taxonName's */ void taxonNameOutput(struct taxonName *el, FILE *f, char sep, char lastSep); /* Print out taxonName. Separate fields with sep. Follow last field with lastSep. */