080a160c7b9595d516c9c70e83689a09b60839d0 galt Mon Jun 3 12:16:53 2013 -0700 fix SQL Injection diff --git src/hg/inc/taxonNode.h src/hg/inc/taxonNode.h index 45f8b07..543f20b 100644 --- src/hg/inc/taxonNode.h +++ src/hg/inc/taxonNode.h @@ -50,42 +50,31 @@ /* Load all taxonNode from tab separated file. * Dispose of this with taxonNodeFreeList(). */ struct taxonNode *taxonNodeLoadByQuery(struct sqlConnection *conn, char *query); /* Load all taxonNode from table that satisfy the query given. * Where query is of the form 'select * from example where something=something' * or 'select example.* from example, anotherTable where example.something = * anotherTable.something'. * Dispose of this with taxonNodeFreeList(). */ void taxonNodeSaveToDb(struct sqlConnection *conn, struct taxonNode *el, char *tableName, int updateSize); /* Save taxonNode as a row to the table specified by tableName. * As blob fields may be arbitrary size updateSize specifies the approx size * of a string that would contain the entire query. Arrays of native types are * converted to comma separated strings and loaded as such, User defined types are - * inserted as NULL. Note that strings must be escaped to allow insertion into the database. - * For example "autosql's features include" --> "autosql\'s features include" - * If worried about this use taxonNodeSaveToDbEscaped() */ - -void taxonNodeSaveToDbEscaped(struct sqlConnection *conn, struct taxonNode *el, char *tableName, int updateSize); -/* Save taxonNode as a row to the table specified by tableName. - * As blob fields may be arbitrary size updateSize specifies the approx size. - * of a string that would contain the entire query. Automatically - * escapes all simple strings (not arrays of string) but may be slower than taxonNodeSaveToDb(). - * For example automatically copies and converts: - * "autosql's features include" --> "autosql\'s features include" - * before inserting into database. */ + * inserted as NULL. Strings are automatically escaped to allow insertion into the database. */ struct taxonNode *taxonNodeCommaIn(char **pS, struct taxonNode *ret); /* Create a taxonNode out of a comma separated string. * This will fill in ret if non-null, otherwise will * return a new taxonNode */ void taxonNodeFree(struct taxonNode **pEl); /* Free a single dynamically allocated taxonNode such as created * with taxonNodeLoad(). */ void taxonNodeFreeList(struct taxonNode **pList); /* Free a list of dynamically allocated taxonNode's */ void taxonNodeOutput(struct taxonNode *el, FILE *f, char sep, char lastSep); /* Print out taxonNode. Separate fields with sep. Follow last field with lastSep. */