080a160c7b9595d516c9c70e83689a09b60839d0 galt Mon Jun 3 12:16:53 2013 -0700 fix SQL Injection diff --git src/hg/inc/wikiTrack.h src/hg/inc/wikiTrack.h index 33d5e00..73182c3 100644 --- src/hg/inc/wikiTrack.h +++ src/hg/inc/wikiTrack.h @@ -59,42 +59,31 @@ /* Load all wikiTrack from tab separated file. * Dispose of this with wikiTrackFreeList(). */ struct wikiTrack *wikiTrackLoadByQuery(struct sqlConnection *conn, char *query); /* Load all wikiTrack from table that satisfy the query given. * Where query is of the form 'select * from example where something=something' * or 'select example.* from example, anotherTable where example.something = * anotherTable.something'. * Dispose of this with wikiTrackFreeList(). */ void wikiTrackSaveToDb(struct sqlConnection *conn, struct wikiTrack *el, char *tableName, int updateSize); /* Save wikiTrack as a row to the table specified by tableName. * As blob fields may be arbitrary size updateSize specifies the approx size * of a string that would contain the entire query. Arrays of native types are * converted to comma separated strings and loaded as such, User defined types are - * inserted as NULL. Note that strings must be escaped to allow insertion into the database. - * For example "autosql's features include" --> "autosql\'s features include" - * If worried about this use wikiTrackSaveToDbEscaped() */ - -void wikiTrackSaveToDbEscaped(struct sqlConnection *conn, struct wikiTrack *el, char *tableName, int updateSize); -/* Save wikiTrack as a row to the table specified by tableName. - * As blob fields may be arbitrary size updateSize specifies the approx size. - * of a string that would contain the entire query. Automatically - * escapes all simple strings (not arrays of string) but may be slower than wikiTrackSaveToDb(). - * For example automatically copies and converts: - * "autosql's features include" --> "autosql\'s features include" - * before inserting into database. */ + * inserted as NULL. Strings are automatically escaped to allow insertion into the database. */ struct wikiTrack *wikiTrackCommaIn(char **pS, struct wikiTrack *ret); /* Create a wikiTrack out of a comma separated string. * This will fill in ret if non-null, otherwise will * return a new wikiTrack */ void wikiTrackFree(struct wikiTrack **pEl); /* Free a single dynamically allocated wikiTrack such as created * with wikiTrackLoad(). */ void wikiTrackFreeList(struct wikiTrack **pList); /* Free a list of dynamically allocated wikiTrack's */ void wikiTrackOutput(struct wikiTrack *el, FILE *f, char sep, char lastSep); /* Print out wikiTrack. Separate fields with sep. Follow last field with lastSep. */