080a160c7b9595d516c9c70e83689a09b60839d0 galt Mon Jun 3 12:16:53 2013 -0700 fix SQL Injection diff --git src/hg/lib/mgiID.c src/hg/lib/mgiID.c index 995e5cf..b21df86 100644 --- src/hg/lib/mgiID.c +++ src/hg/lib/mgiID.c @@ -52,31 +52,31 @@ lineFileClose(&lf); slReverse(&list); return list; } struct MGIid *MGIidLoadWhere(struct sqlConnection *conn, char *table, char *where) /* Load all MGIid from table that satisfy where clause. The * where clause may be NULL in which case whole table is loaded * Dispose of this with MGIidFreeList(). */ { struct MGIid *list = NULL, *el; struct dyString *query = dyStringNew(256); struct sqlResult *sr; char **row; -dyStringPrintf(query, "select * from %s", table); +sqlDyStringPrintf(query, "select * from %s", table); if (where != NULL) dyStringPrintf(query, " where %s", where); sr = sqlGetResult(conn, query->string); while ((row = sqlNextRow(sr)) != NULL) { el = MGIidLoad(row); slAddHead(&list, el); } slReverse(&list); sqlFreeResult(&sr); dyStringFree(&query); return list; } struct MGIid *MGIidCommaIn(char **pS, struct MGIid *ret)