080a160c7b9595d516c9c70e83689a09b60839d0 galt Mon Jun 3 12:16:53 2013 -0700 fix SQL Injection diff --git src/parasol/lib/machSpec.c src/parasol/lib/machSpec.c index de3ca4b..474aba1 100644 --- src/parasol/lib/machSpec.c +++ src/parasol/lib/machSpec.c @@ -56,30 +56,32 @@ slReverse(&list); return list; } #ifdef USING_SQL struct machSpec *machSpecLoadWhere(struct sqlConnection *conn, char *table, char *where) /* Load all machSpec from table that satisfy where clause. The * where clause may be NULL in which case whole table is loaded * Dispose of this with machSpecFreeList(). */ { struct machSpec *list = NULL, *el; struct dyString *query = dyStringNew(256); struct sqlResult *sr; char **row; +// should be changed to sqlDyStringPrintf for NOSQLINJ +// but that would perhaps require moving this code to someplace under hg/ ? dyStringPrintf(query, "select * from %s", table); if (where != NULL) dyStringPrintf(query, " where %s", where); sr = sqlGetResult(conn, query->string); while ((row = sqlNextRow(sr)) != NULL) { el = machSpecLoad(row); slAddHead(&list, el); } slReverse(&list); sqlFreeResult(&sr); dyStringFree(&query); return list; } #endif /* USING_SQL */