a2d2c20d0de2438a151880371da0883df7d1d7cc angie Fri Oct 4 14:01:29 2013 -0700 Refining a 10-year-old kludge for a few tracks that have thickStart=thickEnd=0,but want thick items. There aren't many, but they include wgRna in hg18 and hg19, and hg18.ncRna. Without this additional check for item start != 0, it's possible for the kludge to falsely trigger on items that have thickStart=thickEnd=chromStart when chromStart just happens to be 0, for example in DGV. Of the remaining tracks that need this kludge, none seem to have chromStart=0, so this seems to take care of both new and old tracks. In the long term, it would be best for all tables to just have thickStart=chromStart and thickEnd=chromEnd if they want thick items. fixes #11870 diff --git src/hg/hgTracks/simpleTracks.c src/hg/hgTracks/simpleTracks.c index 6e64f40..1df3aac 100644 --- src/hg/hgTracks/simpleTracks.c +++ src/hg/hgTracks/simpleTracks.c @@ -2616,31 +2616,31 @@ lf->codons = baseColorCodonsFromPsl(lf, psl, sizeMul, isXeno, maxShade, drawOpt, tg); } else if (drawOpt > baseColorDrawOff) { struct genePred *gp = NULL; if (startsWith("genePred", tg->tdb->type)) gp = (struct genePred *)(lf->original); if (gp && gp->cdsStart != gp->cdsEnd) lf->codons = baseColorCodonsFromGenePred(lf, gp, (drawOpt != baseColorDrawDiffCodons), cartUsualBooleanClosestToHome(cart, tg->tdb, FALSE, CODON_NUMBERING_SUFFIX, FALSE)); } if (psl && drawOpt == baseColorDrawCds && !zoomedToCdsColorLevel) baseColorSetCdsBounds(lf, psl, tg); tallStart = lf->tallStart; tallEnd = lf->tallEnd; -if ((tallStart == 0 && tallEnd == 0) && !sameWord(tg->table, "jaxQTL3")) +if ((tallStart == 0 && tallEnd == 0) && lf->start != 0 && !sameWord(tg->table, "jaxQTL3")) { // sometimes a bed <8 will get passed off as a bed 8, tsk tsk tallStart = lf->start; tallEnd = lf->end; } x1 = round((double)((int)lf->start-winStart)*scale) + xOff; x2 = round((double)((int)lf->end-winStart)*scale) + xOff; w = x2-x1; if (lf->start==lf->end && w==0) // like a SNP insertion point of size=0 { w = 1; hvGfxBox(hvg, x1, y, w, heightPer, color); return; }