File Changes for chinhli

v291_preview to v291_preview2 (2013-10-07 to 2013-10-14) v291

• src/hg/encode3/encodeDataWarehouse/edwWebDeprecate/edwWebDeprecate.c
  • lines changed 2, context: html, text, full: html, text
    Base on the Jim's CR 11880 feedbaci note #1:looks good except for edwUserNameFromFileId(struct sqlConnection *conn, int fId). I'd rather this continue to return NULL if the user is not found, and maybe, if you like, have a wrapper function (or the caller function) that converts this NULL to the "an unknown user" This is so that things that want to take a different action for when the user is not found to not have to know what string to search for.
    
    edwUserNameFromFileId will return edwUser or NULL if the user is not found.
    A new wrapper function edwFindOwnerNameFromFileId(struct sqlConnection *conn, int fId) will return either the user name or "an unknown user" if user is not found. edwWebDeprecate will use this new function instead of
    edwUserNameFromFileId.
    
• src/hg/encode3/encodeDataWarehouse/inc/edwLib.h
  • lines changed 6, context: html, text, full: html, text
    Base on the Jim's CR 11880 feedbaci note #1:looks good except for edwUserNameFromFileId(struct sqlConnection *conn, int fId). I'd rather this continue to return NULL if the user is not found, and maybe, if you like, have a wrapper function (or the caller function) that converts this NULL to the "an unknown user" This is so that things that want to take a different action for when the user is not found to not have to know what string to search for.
    
    edwUserNameFromFileId will return edwUser or NULL if the user is not found.
    A new wrapper function edwFindOwnerNameFromFileId(struct sqlConnection *conn, int fId) will return either the user name or "an unknown user" if user is not found. edwWebDeprecate will use this new function instead of
    edwUserNameFromFileId.
    
• src/hg/encode3/encodeDataWarehouse/lib/edwLib.c
  • lines changed 10, context: html, text, full: html, text
    Base on the Jim's CR 11880 feedbaci note #1:looks good except for edwUserNameFromFileId(struct sqlConnection *conn, int fId). I'd rather this continue to return NULL if the user is not found, and maybe, if you like, have a wrapper function (or the caller function) that converts this NULL to the "an unknown user" This is so that things that want to take a different action for when the user is not found to not have to know what string to search for.
    
    edwUserNameFromFileId will return edwUser or NULL if the user is not found.
    A new wrapper function edwFindOwnerNameFromFileId(struct sqlConnection *conn, int fId) will return either the user name or "an unknown user" if user is not found. edwWebDeprecate will use this new function instead of
    edwUserNameFromFileId.