b80cd3175bdb61aa7fe9b8fe15f31dce7fbdb6c3 markd Thu Jan 9 15:18:16 2014 -0800 removed condition that always evaulates to false and generates warnings with LLVM cc diff --git src/hg/lib/bed.c src/hg/lib/bed.c index d7e0a1e..8c029ae 100644 --- src/hg/lib/bed.c +++ src/hg/lib/bed.c @@ -44,32 +44,31 @@ AllocArray(gp->exonStarts, gp->exonCount); AllocArray(gp->exonEnds, gp->exonCount); gp->exonStarts[0] = bed->chromStart; gp->exonEnds[0] = bed->chromEnd; } return gp; } struct bed *bedFromGenePred(struct genePred *genePred) /* Convert a single genePred to a bed structure */ { struct bed *bed; int i, blockCount, *chromStarts, *blockSizes, chromStart; /* A tiny bit of error checking on the genePred. */ -if (genePred->txStart >= genePred->txEnd || genePred->cdsStart > genePred->cdsEnd - || genePred->exonCount < 0 ) +if (genePred->txStart >= genePred->txEnd || genePred->cdsStart > genePred->cdsEnd) { errAbort("mangled genePred format for %s", genePred->name); } /* Allocate bed and fill in from psl. */ AllocVar(bed); bed->chrom = cloneString(genePred->chrom); bed->chromStart = chromStart = genePred->txStart; bed->chromEnd = genePred->txEnd; bed->thickStart = genePred->cdsStart; bed->thickEnd = genePred->cdsEnd; bed->score = 0; strncpy(bed->strand, genePred->strand, sizeof(bed->strand)); bed->blockCount = blockCount = genePred->exonCount; bed->blockSizes = blockSizes = (int *)cloneMem(genePred->exonEnds,(sizeof(int)*genePred->exonCount));