abf840259ead20b793f506b460c48a1bd3512327 hiram Tue Jan 14 14:22:00 2014 -0800 eliminate useless compare of an unsigned int with < 0 refs #12209 diff --git src/hg/hgTables/intersect.c src/hg/hgTables/intersect.c index 11fa527..1ee760b 100644 --- src/hg/hgTables/intersect.c +++ src/hg/hgTables/intersect.c @@ -354,31 +354,31 @@ else for (bed = bedList; bed != NULL; bed = bed->next) { bitSetClippedRange(bits, bitSize, (bed->chromStart - bitOffset), (bed->chromEnd - bitOffset)); } } static int countBasesOverlap(struct bed *bedItem, Bits *bits, boolean hasBlocks, int chromSize) /* Return the number of bases belonging to bedItem covered by bits. */ { int count = 0; int i; -if (bedItem->chromStart < 0 || bedItem->chromEnd > chromSize) +if (bedItem->chromEnd > chromSize) errAbort("Item out of range [0,%d): %s %s:%d-%d", chromSize, (bedItem->name ? bedItem->name : ""), bedItem->chrom, bedItem->chromStart, bedItem->chromEnd); if (bedItem->chromStart == bedItem->chromEnd) { /* Zero-size item: count overlap with adjacent bases. */ for (i = bedItem->chromStart-1; i < bedItem->chromEnd+1; i++) if (i >= 0 && i < chromSize && bitReadOne(bits, i)) count++; } else if (hasBlocks) { for (i=0; i < bedItem->blockCount; i++) {