e5f3b97eec164c6369f6a6beb9274adb7b2bd14d
kate
  Thu Feb 6 17:16:24 2014 -0800
Changes from code review.
diff --git src/hg/hgTrackUi/hgTrackUi.c src/hg/hgTrackUi/hgTrackUi.c
index f16c3bc..fb77ce3 100644
--- src/hg/hgTrackUi/hgTrackUi.c
+++ src/hg/hgTrackUi/hgTrackUi.c
@@ -2477,31 +2477,32 @@
     if (! filterPmIdInCart)
 	slNameAddHead(&checked, pmId);
     if (refCount >= MAX_DGV_REFS)
 	errAbort("dgvUi: %s has too many references (max %d)", tdb->track, MAX_DGV_REFS);
     }
 sqlFreeResult(&sr);
 jsMakeCheckboxGroupSetClearButton(cartVarName, TRUE);
 jsMakeCheckboxGroupSetClearButton(cartVarName, FALSE);
 cgiMakeCheckboxGroupWithVals(cartVarName, labelArr, valueArr, refCount, checked, 4);
 hFreeConn(&conn);
 }
 
 static void factorSourceUi(char *db, struct trackDb *tdb)
 {
 // Multi-select filter on factors
-// NOTE: doesn't currently support track type in composites
+// NOTE: this UI code doesn't currently support the use of factorSource tracks
+// as subtracks in a composite (would require moving to hui.c, using newer cfgByType approach)
 filterBy_t *filters = filterBySetGet(tdb, cart, tdb->track);
 if (filters != NULL)
     {
     puts("<p>");
     filterBySetCfgUi(cart, tdb, filters, TRUE);
     filterBySetFree(&filters);
     }
 
 char varName[64];
 printf("<BR><B>Show cell abbreviations (to right of cluster): </B> ");
 safef(varName, sizeof(varName), "%s.showCellAbbrevs", tdb->track);
 cartMakeCheckBox(cart, varName, TRUE);
 
 puts("<p><table>");
 jsBeginCollapsibleSectionFontSize(cart, tdb->track, "cellSources", "Cell Abbreviations", FALSE,