3b80c5be2a2d43f71277f8cd9274e3c49d9ad6c2 angie Mon Feb 24 16:54:33 2014 -0800 Improved error messages for bigData custom track common mistakes likemissing bigDataUrl setting or trying to upload a bigData file instead of making a track line with a public URL. I added a new "factory" to customFactory.c that produces no tracks, only error messages about directly uploaded bigData files. refs #12747 diff --git src/hg/lib/customPp.c src/hg/lib/customPp.c index d87e36e..112fc2d 100644 --- src/hg/lib/customPp.c +++ src/hg/lib/customPp.c @@ -1,136 +1,145 @@ /* customPp - custom track preprocessor. This handles the line-oriented * input/output for the custom track system. The main services it provides * are taking care of references to URLs, which are treated as includes, * and moving lines that start with "browser" to a list. * * Also this allows unlimited "pushBack" of lines, which is handy, since * the system will analyse a number of lines of a track to see what format * it's in. */ #include "common.h" #include "linefile.h" #include "net.h" #include "customPp.h" #ifdef PROGRESS_METER #include "udc.h" #endif struct customPp *customDocPpNew(struct lineFile *lf) /* Return customPp that will ignore browser lines, for doc files */ { struct customPp *cpp = customPpNew(lf); cpp->ignoreBrowserLines = TRUE; return cpp; } struct customPp *customPpNew(struct lineFile *lf) /* Return customPp on lineFile */ { struct customPp *cpp; AllocVar(cpp); cpp->fileStack = lf; return cpp; } void customPpFree(struct customPp **pCpp) /* Close files and free up customPp. */ { struct customPp *cpp = *pCpp; if (cpp) { lineFileCloseList(&cpp->fileStack); slFreeList(&cpp->browserLines); slFreeList(&cpp->reusedLines); freeMem(cpp->inReuse); } } char *customPpNext(struct customPp *cpp) /* Return next line. */ { /* Check first for line to reuse. */ struct slName *reused = cpp->reusedLines; if (reused) { /* We need to keep line actually reusing in memory until next * call to customPpNext, so we move it to inReuse rather than * immediately freeing it. */ freeMem(cpp->inReuse); cpp->reusedLines = reused->next; cpp->inReuse = reused; return reused->name; } /* Get next line from file on top of stack. If at EOF * go to next file in stack. If get a http:// or https:// or ftp:// line * open file this references and push it onto stack. Meanwhile * squirrel away 'browser' lines. */ struct lineFile *lf; while ((lf = cpp->fileStack) != NULL) { char *line; if (lineFileNext(lf, &line, NULL)) { if (startsWith("http://", line) || startsWith("https://", line) || startsWith("ftp://", line)) { lf = netLineFileOpen(line); slAddHead(&cpp->fileStack, lf); #ifdef PROGRESS_METER off_t remoteSize = 0; remoteSize = remoteFileSize(line); cpp->remoteFileSize = remoteSize; #endif continue; } else if (!cpp->ignoreBrowserLines && startsWith("browser", line)) { char afterPattern = line[7]; if (isspace(afterPattern) || afterPattern == 0) { slNameAddTail(&cpp->browserLines, line); continue; } } return line; } else { cpp->fileStack = lf->next; lineFileClose(&lf); } } return NULL; } char *customPpNextReal(struct customPp *cpp) /* Return next line that's nonempty and non-space. */ { for (;;) { char *line = customPpNext(cpp); if (line == NULL) return line; char *s = skipLeadingSpaces(line); char c = *s; if (c != 0 && c != '#') return line; } } void customPpReuse(struct customPp *cpp, char *line) /* Reuse line. May be called many times before next customPpNext/NextReal. * Should be called with last line to be reused first if called multiply. */ { struct slName *s = slNameNew(line); slAddHead(&cpp->reusedLines, s); } struct slName *customPpTakeBrowserLines(struct customPp *cpp) /* Grab browser lines from cpp, which will no longer have them. */ { struct slName *browserLines = cpp->browserLines; cpp->browserLines = NULL; return browserLines; } + +char *customPpFileName(struct customPp *cpp) +/* Return the name of the current file being parsed (top of fileStack), or NULL + * if fileStack is NULL. Free when done. */ +{ +if (cpp->fileStack == NULL) + return NULL; +return cloneString(cpp->fileStack->fileName); +}