3329f549f0718e84b05bff2c792cdfe697d8d209 braney Tue Apr 22 17:20:18 2014 -0700 some tweaks in response to code review. Provide a default assembly nameinstead of (null), and add default case to switches on enumerated typed variables. refs #13118 diff --git src/hg/hgTracks/multiWig.c src/hg/hgTracks/multiWig.c index 994bb52..2dade16 100644 --- src/hg/hgTracks/multiWig.c +++ src/hg/hgTracks/multiWig.c @@ -189,30 +189,35 @@ double val; switch(windowingFunction) { case wiggleWindowingMean: val = p->sumData / p->count; break; case wiggleWindowingWhiskers: case wiggleWindowingMax: val = p->max; break; case wiggleWindowingMin: val = p->min; break; + default: + { + errAbort("bad windowing function (value: %d)\n", windowingFunction); + break; + } } if (p->count) { if (yOffsets) yOffsets[offset] = val; else { if (min > val) min = val; if (max < val) max = val; } } else if (yOffsets) { yOffsets[offset] = 0; } @@ -251,30 +256,35 @@ floatPicSet(floatPic, 1, 1, 1); wgo = wigGraphOutputTransparent(floatPic); break; } case wiggleAggregateNone: case wiggleAggregateSolid: { wgo = wigGraphOutputSolid(xOff, yOff, hvg); break; } case wiggleAggregateStacked: { wgo = wigGraphOutputStack(xOff, yOff, width, numTracks, hvg); break; } + default: + { + errAbort("bad aggregate function (value: %d)\n", wigCart->aggregateFunction); + break; + } } return wgo; } static void multiWigDraw(struct track *tg, int seqStart, int seqEnd, struct hvGfx *hvg, int xOff, int yOff, int width, MgFont *font, Color color, enum trackVisibility vis) /* Draw items in multiWig container. */ { struct track *subtrack; boolean errMsgShown = FALSE; int y = yOff; boolean errMsgFound = FALSE; int numTracks = 0;