78349c78059d29f80919916fdbf82416333fd473
chinhli
  Fri Apr 11 16:20:24 2014 -0700
Feed back from CR #13033Rename geneReviewsGeneGRshortNBKidGRtitle to geneReviewsDetail
Add a comment in the geneReviewsGrshortNBKid.sql and geneReviewsGrshortTitleNBKid.sql
to let reader know they are temp files used by track build.

diff --git src/hg/hgc/geneReviewsClick.c src/hg/hgc/geneReviewsClick.c
index c2bbef7..15f2226 100644
--- src/hg/hgc/geneReviewsClick.c
+++ src/hg/hgc/geneReviewsClick.c
@@ -21,34 +21,34 @@
 
 void prGeneReviews(struct sqlConnection *conn, char *itemName)
 /* print GeneReviews associated to this item
    Note: this print function has been replaced by addGeneReviewToBed.pl
          which print the same information to the field 5 of bigBed file
 */
 {
 struct sqlResult *sr;
 char **row;
 char query[512];
 int i;
 char *clickMsg = "Click GR short name link to find the GeneReviews article on NCBI Bookshelf.";
 char *spacer = "   ";
 boolean firstTime = TRUE;
 
-if (!sqlTableExists(conn, "geneReviewsGeneGRshortNBKidGRtitle")) return;
+if (!sqlTableExists(conn, "geneReviewsDetail")) return;
 
 
-sqlSafef(query, sizeof(query), "select  grShort, NBKid, grTitle from geneReviewsGeneGRshortNBKidGRtitle where geneSymbol='%s'", itemName);
+sqlSafef(query, sizeof(query), "select  grShort, NBKid, grTitle from geneReviewsDetail where geneSymbol='%s'", itemName);
 
 sr = sqlGetResult(conn, query);
 while ((row = sqlNextRow(sr)) != NULL)
     {
         char *grShort = *row++;
         char *NBKid  = *row++;
         char *grTitle = *row++;
 
 
         if (firstTime)
         {
           printf("<BR><B> GeneReviews available for %s:</B> (%s)<BR>",itemName,clickMsg);
           firstTime = FALSE;
           printf("<PRE><TT>");
               // #123456789-123456789-123456789-123456789-123456789-123456789-
@@ -69,45 +69,45 @@
 //        printf("<A HREF=\"http://www.ncbi.nlm.nih.gov/books/%s\" TARGET=_blank><B>%s</B></A>%s%s<BR>", NBKid, NBKid, spacer, grTitle);
     }  /* end while */
  printf("</TT></PRE>");
  sqlFreeResult(&sr);
 } /* end of prGeneReviews */
 
 void prGRShortRefGene(char *itemName)
 /* print GeneReviews short label associated to this refGene item */
 {
 struct sqlConnection *conn  = hAllocConn(database);
 struct sqlResult *sr;
 char **row;
 char query[512];
 boolean firstTime = TRUE;
 
-if (!sqlTableExists(conn, "geneReviewsGeneGRshortNBKidGRtitle")) return;
+if (!sqlTableExists(conn, "geneReviewsDetail")) return;
 
-sqlSafef(query, sizeof(query), "select grShort, NBKid, grTitle from geneReviewsGeneGRshortNBKidGRtitle where geneSymbol='%s'", itemName);
+sqlSafef(query, sizeof(query), "select grShort, NBKid, grTitle from geneReviewsDetail where geneSymbol='%s'", itemName);
 
 sr = sqlGetResult(conn, query);
 while ((row = sqlNextRow(sr)) != NULL)
     {
         char *grShort = *row++;
 	char *NBKid = *row++;
         char *grTitle = *row++;
         if (firstTime)
         {
           printf("<B>Related GeneReviews disease(s): </B>");
           firstTime = FALSE;
-       printf("<A HREF=\"http://www.ncbi.nlm.nih.gov/books/n/gene/%s\" TARGET=_blank><B>%s</B></A>", grShort, grShort);
+       printf("<A HREF=\"http://www.ncbi.nlm.nih.gov/books/%s\" TARGET=_blank><B>%s</B></A>", NBKid, grShort);
         printf(" (");
        printf("<A HREF=\"http://www.ncbi.nlm.nih.gov/books/%s\" TARGET=_blank>%s</A>", NBKid, grTitle);
        printf(")");
         } else {
           printf(", ");
        printf("<A HREF=\"http://www.ncbi.nlm.nih.gov/books/n/gene/%s\" TARGET=_blank><B>%s</B></A>", grShort, grShort);
        printf(" (");
        printf("<A HREF=\"http://www.ncbi.nlm.nih.gov/books/%s\" TARGET=_blank>%s</A>", NBKid, grTitle);
        printf(")");
         }
      }
      printf("<BR>");
      sqlFreeResult(&sr);
 } /* end of prGRShortRefGene */