cacd6a61225720a10e127624f97ed0de2ef58c85 angie Wed May 14 16:19:23 2014 -0700 Mac OS X Mavericks gcc -Wall complained about the parentheses in this "if"condition split up by #ifdef/#else/#endif. Fix: simplify the syntax so the "if" condition is not split. diff --git src/hg/hgTracks/cds.c src/hg/hgTracks/cds.c index e9ee1c7..dceefde 100644 --- src/hg/hgTracks/cds.c +++ src/hg/hgTracks/cds.c @@ -1758,35 +1758,35 @@ } } } void baseColorInitTrack(struct hvGfx *hvg, struct track *tg) /* Set up base coloring state (e.g. cache genomic sequence) for tg. * This must be called by tg->drawItems if baseColorDrawSetup is used * in tg->drawItemAt. Peeks at tg->drawItems method to determine whether * tg is linkedFeatures or linkedFeaturesSeries (currently the only * two supported track types -- bed, psl etc. are subclasses of these). */ { if (initedTrack == NULL || differentString(tg->track, initedTrack)) { int overallStart, overallEnd; boolean isSeries = FALSE; - if ((tg->drawItems == linkedFeaturesSeriesDraw) #ifdef USE_BAM - || (tg->drawItems == bamLinkedFeaturesSeriesDraw)) + if (tg->drawItems == linkedFeaturesSeriesDraw + || tg->drawItems == bamLinkedFeaturesSeriesDraw) #else - ) + if (tg->drawItems == linkedFeaturesSeriesDraw) #endif isSeries = TRUE; else if (!baseColorCanDraw(tg)) errAbort("baseColorInitTrack: track %s has a type not recognized by baseColorCanDraw.", tg->track); getLinkedFeaturesSpan((struct linkedFeatures *)tg->items, &overallStart, &overallEnd, isSeries); if (overallStart < cachedGenoStart || overallEnd > cachedGenoEnd) { // leak mem to save time (don't bother freeing old cached dna) cachedGenoStart = overallStart; cachedGenoEnd = overallEnd; cachedGenoDna = hDnaFromSeq(database, chromName, cachedGenoStart, cachedGenoEnd, dnaUpper); } initedTrack = cloneString(tg->track);