Commits for angie

v312_preview to v312_preview2 (2015-02-02 to 2015-02-09) v312

• Code review feedback from Brian Craft: use _. functions instead of Object.keys(thing).forEach.
  
  • src/hg/js/model/hgAi/hgAiModel.js - lines changed 3, context: html, text, full: html, text
  • src/hg/js/model/lib/ImModel.js - lines changed 2, context: html, text, full: html, text
  • src/hg/js/model/lib/cart.js - lines changed 22, context: html, text, full: html, text
• Code review feedback from Brian C: separate out the logic that traverses
  the uiHandlers tree from the code that installs or executes handler functions.
  
  • src/hg/js/model/lib/ImModel.js - lines changed 50, context: html, text, full: html, text
• Code review feedback from Brian C:
  1. Making a temporary this.mutState that all handlers implicitly have
  access to via this is almost as bad as using a global variable.
  Instead, pass mutState as a function arg so it's very clear where
  it's coming from.
  Brian suggested going a step farther and returning mutState from
  every handler so that the handler functions could be _.compose'd,
  but I'll be stubborn and stick with explicit side effects and _.forEach.
  2. Tighten up jshint warnings -- it is very lax by default.
  I should have done #2 first and then embarked on #1 as a separate commit,
  but after doing #1 I wanted jshint checks to help me find places I forgot
  to update so it's all mashed together, sorry.
  
  • src/hg/js/jshintrc.json - lines changed 16, context: html, text, full: html, text
  • src/hg/js/model/hgAi/hgAiModel.js - lines changed 58, context: html, text, full: html, text
  • src/hg/js/model/hgAi/makefile - lines changed 4, context: html, text, full: html, text
  • src/hg/js/model/hgChooseDb/hgChooseDbModel.js - lines changed 14, context: html, text, full: html, text
  • src/hg/js/model/hgChooseDb/makefile - lines changed 4, context: html, text, full: html, text
  • src/hg/js/model/lib/CladeOrgDbMixin.js - lines changed 10, context: html, text, full: html, text
  • src/hg/js/model/lib/ImModel.js - lines changed 18, context: html, text, full: html, text
  • src/hg/js/model/lib/PositionSearchMixin.js - lines changed 16, context: html, text, full: html, text
  • src/hg/js/model/lib/cart.js - lines changed 6, context: html, text, full: html, text
  • src/hg/js/model/lib/makefile - lines changed 4, context: html, text, full: html, text
  • src/hg/js/react/mixins/ImmutableUpdate.js - lines changed 9, context: html, text, full: html, text
  • src/hg/js/react/mixins/PathUpdate.js - lines changed 4, context: html, text, full: html, text
  • src/hg/js/react/mixins/PathUpdateOptional.js - lines changed 4, context: html, text, full: html, text
  • src/hg/js/react/mixins/makefile - lines changed 4, context: html, text, full: html, text
  • src/hg/js/simple.mk - lines changed 1, context: html, text, full: html, text
• Hooked in stricter jshint config to jsxhint for React/JSX *.jsx files.
  
  • src/hg/js/react/hgAi/hgAi.jsx - lines changed 15, context: html, text, full: html, text
  • src/hg/js/react/hgAi/makefile - lines changed 4, context: html, text, full: html, text
  • src/hg/js/react/hgChooseDb/hgChooseDb.jsx - lines changed 17, context: html, text, full: html, text
  • src/hg/js/react/hgChooseDb/makefile - lines changed 4, context: html, text, full: html, text
  • src/hg/js/react/lib/CheckboxLabel.jsx - lines changed 4, context: html, text, full: html, text
  • src/hg/js/react/lib/CladeOrgDb.jsx - lines changed 5, context: html, text, full: html, text
  • src/hg/js/react/lib/Icon.jsx - lines changed 6, context: html, text, full: html, text
  • src/hg/js/react/lib/LabeledSelect.jsx - lines changed 8, context: html, text, full: html, text
  • src/hg/js/react/lib/LoadingImage.jsx - lines changed 6, context: html, text, full: html, text
  • src/hg/js/react/lib/Modal.jsx - lines changed 6, context: html, text, full: html, text
  • src/hg/js/react/lib/PositionSearch.jsx - lines changed 11, context: html, text, full: html, text
  • src/hg/js/react/lib/Section.jsx - lines changed 3, context: html, text, full: html, text
  • src/hg/js/react/lib/SetClearButtons.jsx - lines changed 4, context: html, text, full: html, text
  • src/hg/js/react/lib/Sortable.jsx - lines changed 6, context: html, text, full: html, text
  • src/hg/js/react/lib/TextInput.jsx - lines changed 4, context: html, text, full: html, text
  • src/hg/js/react/lib/makefile - lines changed 3, context: html, text, full: html, text
  • src/hg/js/react/react.mk - lines changed 1, context: html, text, full: html, text
• Better workaround for jshint warning about unused file-module variable: bogus assignment instead of disabling the check.
  
  • src/hg/js/model/lib/CladeOrgDbMixin.js - lines changed 8, context: html, text, full: html, text
  • src/hg/js/model/lib/PositionSearchMixin.js - lines changed 7, context: html, text, full: html, text
  • src/hg/js/model/lib/cart.js - lines changed 8, context: html, text, full: html, text
  • src/hg/js/react/mixins/ImmutableUpdate.js - lines changed 5, context: html, text, full: html, text
  • src/hg/js/react/mixins/PathUpdate.js - lines changed 7, context: html, text, full: html, text
  • src/hg/js/react/mixins/PathUpdateOptional.js - lines changed 7, context: html, text, full: html, text