e4d147ce10b367323649bd6e207196ffeccec02f markd Thu Jun 25 07:53:21 2015 -0700 fixed buffer overflow in extreme test case (no readmind) diff --git src/hg/lib/genePred.c src/hg/lib/genePred.c index cb671bb..189196b 100644 --- src/hg/lib/genePred.c +++ src/hg/lib/genePred.c @@ -843,31 +843,31 @@ { /* adjust CDS to include stop codon as in GTF */ if (group->strand == '+') { if (stopCodonEnd > cdsEnd) cdsEnd = stopCodonEnd; } else { if (stopCodonStart < cdsStart) cdsStart = stopCodonStart; } } /* add in version numbers if requested and available */ -char geneIdToUse[512], transcriptIdToUse[512]; +char geneIdToUse[1024], transcriptIdToUse[1024]; geneIdToUse[0]= '\0'; if (options & genePredGxfGeneNameAsName2) { if (group->lineList->geneName != NULL) safecpy(geneIdToUse, sizeof(geneIdToUse), group->lineList->geneName); } else if (group->lineList->geneId != NULL) { if (genePredGxfIncludeVersion && (group->lineList->geneVersion != NULL)) safef(geneIdToUse, sizeof(geneIdToUse), "%s.%s", group->lineList->geneId, group->lineList->geneVersion); else safecpy(geneIdToUse, sizeof(geneIdToUse), group->lineList->geneId); } if (genePredGxfIncludeVersion && (group->lineList->transcriptVersion != NULL)) safef(transcriptIdToUse, sizeof(transcriptIdToUse), "%s.%s", name, group->lineList->transcriptVersion);