0999158088e0fb3715eb27703c8c4f7123d77144
galt
  Mon Sep 21 16:51:20 2015 -0700
added GNU-C attributes to function declarations in src/inc, src/hg/inc, and some CGIs so that the compiler can catch errors where the parameter list given by the user does not match their format string. These var-args functions are like printf.

diff --git src/inc/jsonWrite.h src/inc/jsonWrite.h
index b5efb25..7079f8b 100644
--- src/inc/jsonWrite.h
+++ src/inc/jsonWrite.h
@@ -1,87 +1,92 @@
 /* jsonWrite - Helper routines for writing out JSON.  The idea of this is you build up a string inside
  * of the jsonWrite object using various jsonWrite methods, and then output the string where you want.
  *
  * struct jsonWrite *jw = jsonWriteNew();
  * jsonWriteObjectStart(jw, NULL);		// Anonymous outer object 
  * jsonWriteStringf(jw, "user", "%s %s", user->firstName, user->lastName);
  * jsonWriteNumber(jw, "year", 2015);
  * jsonWriteObjectEnd(jw);
  * printf("%s\n", jw->dy->string);
  * jsonWriteFree(&jw);
  */
 
 
 #ifndef JSONWRITE_H
 #define JSONWRITE_H
 
 struct jsonWrite
 /* Object to help output JSON */
      {
      struct jsonWrite *next;
      struct dyString *dy;	/* Most of this module is building json text in here */
      bool objStack[128];	/* We need stack deep enough to handle nested objects and lists */
      int stackIx;		/* Current index in stack */
      };
 
 struct jsonWrite *jsonWriteNew();
 /* Return new empty jsonWrite struct. */
 
 void jsonWriteFree(struct jsonWrite **pJw);
 /* Free up a jsonWrite object. */
 
 void jsonWriteTag(struct jsonWrite *jw, char *var);
 /* Print out quoted tag followed by colon. Print out preceding comma if need be.  */
 
 void jsonWriteEndLine(struct jsonWrite *jw);
 /* Write comma if in middle, and then newline regardless. */
 
 void jsonWriteString(struct jsonWrite *jw, char *var, char *string);
 /* Print out "var": "val".  If var is NULL, print val only.  If string is NULL, "var": null . */
 
 void jsonWriteDateFromUnix(struct jsonWrite *jw, char *var, long long unixTimeVal);
 /* Add "var": YYYY-MM-DDT-HH:MM:SSZ given a Unix time stamp. Var may be NULL. */
 
 void jsonWriteNumber(struct jsonWrite *jw, char *var, long long val);
 /* print out "var": val as number. Var may be NULL. */
 
 void jsonWriteDouble(struct jsonWrite *jw, char *var, double val);
 /* print out "var": val as number. Var may be NULL. */
 
 void jsonWriteLink(struct jsonWrite *jw, char *var, char *objRoot, char *name);
 /* Print out the jsony type link to another object.  objRoot will start and end with a '/'
  * and may have additional slashes in this usage. Var may be NULL. */
 
 void jsonWriteLinkNum(struct jsonWrite *jw, char *var, char *objRoot, long long id);
 /* Print out the jsony type link to another object with a numerical id.  objRoot will start 
  * and end with a '/' and may have additional slashes in this usage. Var may be NULL */
 
 void jsonWriteListStart(struct jsonWrite *jw, char *var);
 /* Start an array in JSON. Var may be NULL */
 
 void jsonWriteListEnd(struct jsonWrite *jw);
 /* End an array in JSON */
 
 void jsonWriteObjectStart(struct jsonWrite *jw, char *var);
 /* Print start of object, preceded by tag if var is non-NULL. */
 
 void jsonWriteObjectEnd(struct jsonWrite *jw);
 /* End object in JSON */
 
-void jsonWriteStringf(struct jsonWrite *jw, char *var, char *format, ...);
+void jsonWriteStringf(struct jsonWrite *jw, char *var, char *format, ...)
 /* Write "var": "val" where val is jsonStringEscape'd formatted string. */
+#if defined(__GNUC__)
+__attribute__((format(printf, 3, 4)))
+#endif
+;
+
 
 void jsonWriteBoolean(struct jsonWrite *jw, char *var, boolean val);
 /* Write out "var": true or "var": false depending on val (no quotes around true/false). */
 
 void jsonWriteValueLabelList(struct jsonWrite *jw, char *var, struct slPair *pairList);
 /* Print out a named list of {"value": "<pair->name>", "label": "<pair->val>"} objects. */
 
 void jsonWriteSlNameList(struct jsonWrite *jw, char *var, struct slName *slnList);
 /* Print out a named list of strings from slnList. */
 
 void jsonWriteAppend(struct jsonWrite *jwA, char *var, struct jsonWrite *jwB);
 /* Append jwB's contents to jwA's.  If jwB is non-NULL, it must be fully closed (no unclosed
  * list or object).  If var is non-NULL, write it out as a tag before appending.
  * If both var and jwB are NULL, leave jwA unchanged. */
 
 #endif /* JSONWRITE_H */