17c23271d8e3b97b89d6e3b9ded90d1c14d3e23d max Tue Nov 3 00:25:20 2015 -0800 fixing off-by-one errors in external tools menu, refs #16308 diff --git src/hg/js/hgTracks.js src/hg/js/hgTracks.js index de6e6d3..a0824ae 100644 --- src/hg/js/hgTracks.js +++ src/hg/js/hgTracks.js @@ -2702,31 +2702,31 @@ if ((maxSize===0) || (winSize < maxSize)) { var url = "hgTracks?hgsid="+getHgsid()+"&hgt.redirectTool="+toolId; var onclick = "$('#extToolDialog').dialog('close');"; htmlLines.push("<li><a onclick="+'"'+onclick+'"'+"id='extToolLink' target='_BLANK' href='"+url+"'>"+shortLabel+"</a>: <small>"+longLabel+"</small></li>"); } else { note = "<br><b>Needs zoom to < "+maxSize/1000+" kbp.</b></small></span></li>"; htmlLines.push('<li><span style="color:grey">'+shortLabel+": <small>"+longLabel+note); } } htmlLines.push("</ul>"); content = htmlLines.join(""); - var title = hgTracks.chromName + ":" + hgTracks.winStart + "-" + hgTracks.winEnd + " on another website"; + var title = hgTracks.chromName + ":" + (hgTracks.winStart+1) + "-" + hgTracks.winEnd + " on another website"; $("body").append("<div id='extToolDialog' title='"+title+"'><p>" + content + "</p>"); // copied from the hgTrackUi function below var popMaxHeight = ($(window).height() - 40); var popMaxWidth = ($(window).width() - 40); var popWidth = 600; if (popWidth > popMaxWidth) popWidth = popMaxWidth; // also copied from the hgTrackUi code below $('#extToolDialog').dialog({ resizable: true, // Let description scroll vertically height: popMaxHeight, width: popWidth, minHeight: 200,