3e0c0cd8668c45d82cbc80e42fb79ac3a9fd7e9a
hiram
  Tue Nov 24 15:31:49 2015 -0800
fixup gcc warnings for -Wunused-but-set-variable refs #16121

diff --git src/hg/hgTablesTest/hgTablesTest.c src/hg/hgTablesTest/hgTablesTest.c
index c032b62..a4a11ad 100644
--- src/hg/hgTablesTest/hgTablesTest.c
+++ src/hg/hgTablesTest/hgTablesTest.c
@@ -132,48 +132,49 @@
 	char *testName, char *button, char *buttonVal)
 /* Submit page and record info.  Return NULL if a problem. */
 {
 struct htmlPage *page = NULL;
 
 // don't get ahead of the botDelay
 sleep1000(5000);
 
 verbose(2, "quickSubmit(%p, %s, %s, %s, %s, %s, %s, %s, %s)\n",
 	basePage, naForNull(org), naForNull(db), naForNull(group), 
 	naForNull(track), naForNull(table), naForNull(testName), 
 	naForNull(button), naForNull(buttonVal));
 if (basePage != NULL)
     {
     struct qaStatus *qs;
-    struct tablesTest *test;
     if (db != NULL)
 	htmlPageSetVar(basePage, NULL, "db", db);
     if (org != NULL)
 	htmlPageSetVar(basePage, NULL, "org", org);
     if (group != NULL)
         htmlPageSetVar(basePage, NULL, hgtaGroup, group);
     if (track != NULL)
         htmlPageSetVar(basePage, NULL, hgtaTrack, track);
     if (table != NULL)
         htmlPageSetVar(basePage, NULL, hgtaTable, table);
     qs = qaPageFromForm(basePage, basePage->forms, 
 	    button, buttonVal, &page);
     /* 
     if (page->forms != NULL)
         htmlFormPrint(page->forms, stdout);
     */
-    test = tablesTestNew(qs, testName, org, db, group, track, table);
+    // do not need to keep the returned structure, the answer is accumulating
+    // in global variable: tablesTestList
+    (void) tablesTestNew(qs, testName, org, db, group, track, table);
     }
 return page;
 }
 
 void serialSubmit(struct htmlPage **pPage,
 	char *org, char *db, char *group, char *track, char *table,
 	char *testName, char *button, char *buttonVal)
 /* Submit page, replacing old page with new one. */
 {
 struct htmlPage *oldPage = *pPage;
 if (oldPage != NULL)
     {
     *pPage = quickSubmit(oldPage, org, db, group, track, table,
     	testName, button, buttonVal);
     htmlPageFree(&oldPage);
@@ -290,31 +291,30 @@
 	qaStatusSoftError(tablesTestList->status, 
 		"Got %d rows, expected %d", rowCount, expectedRows);
     }
 }
 
 void testOneField(struct htmlPage *tablePage, struct htmlForm *mainForm,
      char *org, char *db, char *group, char *track, char *table, 
      int expectedRows)
 /* Get one field and make sure the count agrees with expected. */
 /* mainForm not used */
 {
 struct htmlPage *outPage;
 struct htmlForm *form;
 struct htmlFormVar *var;
 int attempts = 0;
-int rowCount = 0;
 
 if (tablePage->forms == NULL) 
      errAbort("testOneField: Missing form (tablePage)");
 
 htmlPageSetVar(tablePage, NULL, hgtaOutputType, "selectedFields");
 
 outPage = quickSubmit(tablePage, org, db, group, track, table,
     "selFieldsPage", hgtaDoTopSubmit, "submit");
 while (outPage == NULL && attempts < MAX_ATTEMPTS)
     {
     printf("testOneField: trying again to get selFieldsPage\n");
     outPage = quickSubmit(tablePage, org, db, group, track, table,
         "selFieldsPage", hgtaDoTopSubmit, "submit");
     attempts++;
     }
@@ -323,31 +323,30 @@
     {
     qaStatusSoftError(tablesTestList->status,
            "Error in testOneField - couldn't get outPage.");
     return;
     }
 
 if (outPage->forms == NULL)
     {
     qaStatusSoftError(tablesTestList->status,
            "Error in testOneField - missing form.");
     htmlPageFree(&outPage);
     return;
 }
 
 form = outPage->forms;
-rowCount = 0;
 var = findPrefixedVar(form->vars, "hgta_fs.check.");
 if (var == NULL)
     errAbort("No hgta_fs.check. vars in form");
 htmlPageSetVar(outPage, NULL, var->name, "on");
 serialSubmit(&outPage, org, db, group, track, table, "oneField",
     hgtaDoPrintSelectedFields, "submit");
 // check that outPage != NULL
 checkExpectedSimpleRows(outPage, expectedRows);
 htmlPageFree(&outPage);
 }
 	
 void testOutBed(struct htmlPage *tablePage, struct htmlForm *mainForm,
      char *org, char *db, char *group, char *track, char *table, 
      int expectedRows)
 /* Get as bed and make sure count agrees with expected. */