7848983f6852bfa679439cdd644eb6924edfb646 max Tue Jun 21 13:47:55 2016 -0700 not showing outlink when url is empty string, refs #17134 diff --git src/hg/hgc/hgc.c src/hg/hgc/hgc.c index fdb3bd1..5798e80 100644 --- src/hg/hgc/hgc.c +++ src/hg/hgc/hgc.c @@ -997,31 +997,31 @@ } \ \ \ \

", eUrl, iframeOptions); } void printCustomUrlWithLabel(struct trackDb *tdb, char *itemName, char *itemLabel, char *urlSetting, boolean encode) /* Print custom URL specified in trackDb settings. */ { char urlLabelSetting[32]; // replace the $$ and other wildchards with the url given in tdb char *url = getUrlSetting(tdb, "url"); //char* eUrl = constructUrl(tdb, url, itemName, encode); -if (url==NULL) +if (url==NULL || isEmpty(url)) return; char* eUrl = replaceInUrl(url, itemName, cart, database, seqName, winStart, winEnd, tdb->track, encode); if (eUrl==NULL) return; /* create the url label setting for trackDb from the url setting prefix */ safef(urlLabelSetting, sizeof(urlLabelSetting), "%sLabel", urlSetting); char *linkLabel = trackDbSettingOrDefault(tdb, urlLabelSetting, "Outside Link:"); // if we got no item name from hgTracks or the item name does not appear in the URL // there is no need to show the item name at all if (isEmpty(itemName) || !stringIn("$$", url)) {