042d859041f3d41a654f4d5590bbf5f91702d1ca angie Wed Jul 13 14:19:20 2016 -0700 Remove code that forces all hgTracks <a> links to POST. Ironically, although this was intended to apply to map area items, those are not <a> elements. Clicking on map items causes a POST because of mapClk, not the lines I'm removing here. Forcing POST can cause downstream problems, e.g. Jonathan had to prevent the genome-store link from being a POST, and posting to index.html caused a strange post to be sent to hgMenubar. refs #17703 #17622#note-44 diff --git src/hg/js/hgTracks.js src/hg/js/hgTracks.js index 988d252..a8935f4 100644 --- src/hg/js/hgTracks.js +++ src/hg/js/hgTracks.js @@ -4435,37 +4435,30 @@ // The page may be reached via browser history (back button) // If so, then this code should detect if the image has been changed via js/ajax // and will reload the image if necessary. // NOTE: this is needed for IE but other browsers can detect the dirty page much earlier if (!imageV2.backSupport) { if (imageV2.isDirtyPage()) { // mark as non dirty to avoid infinite loop in chrome. imageV2.markAsCleanPage(); jQuery('body').css('cursor', 'wait'); window.location = "../cgi-bin/hgTracks?hgsid=" + getHgsid(); return false; } } initVars(); imageV2.loadSuggestBox(); - // Convert map AREA gets to post the form, ensuring that cart variables are kept - // up to date (but turn this off for search form). - if ($("FORM").length > 0 && $('#trackSearch').length === 0) { - var allLinks = $('a[class!=noPostLink]'); - $( allLinks ).unbind('click'); - $( allLinks ).click( posting.saveSettings ); - } if ($('#pdfLink').length === 1) { $('#pdfLink').click(function(i) { var thisForm = normed($('#TrackForm')); if (thisForm) { //alert("posting form:"+$(thisForm).attr('name')); updateOrMakeNamedVariable($(thisForm),'hgt.psOutput','on'); return postTheForm($(thisForm).attr('name'),this.href); } return true; }); } if (imageV2.enabled) { // Make imgTbl allow drag reorder of imgTrack rows