2160baec63f853659980b53f4cda17cd56ac31e7 galt Thu Aug 11 14:08:42 2016 -0700 Revert "Fixes XSS for the early warning and abort messages. These were detected by system admins in Japan" This reverts commit 4cfc3d3eb5486c004765de17570c548ea6c388d5. diff --git src/hg/lib/cart.c src/hg/lib/cart.c index 0997d3f..2b43a38 100644 --- src/hg/lib/cart.c +++ src/hg/lib/cart.c @@ -1640,31 +1640,31 @@ popAbortHandler(); } void cartEarlyWarningHandler(char *format, va_list args) /* Write an error message so user can see it before page is really started. */ { static boolean initted = FALSE; va_list argscp; va_copy(argscp, args); if (!initted) { htmStart(stdout, "Early Error"); initted = TRUE; } printf("%s", htmlWarnStartPattern()); -htmlVaEncodeErrorText(format,args); +htmlVaParagraph(format,args); printf("%s", htmlWarnEndPattern()); /* write warning/error message to stderr so they get logged. */ logCgiToStderr(); vfprintf(stderr, format, argscp); va_end(argscp); putc('\n', stderr); fflush(stderr); } void cartWarnCatcher(void (*doMiddle)(struct cart *cart), struct cart *cart, WarnHandler warner) /* Wrap error and warning handlers around doMiddle. */ { pushWarnHandler(warner); cartErrorCatcher(doMiddle, cart);