4bb621ce7eb13b685bf5c9fde408220abda8d35e
angie
  Wed Aug 24 12:08:48 2016 -0700
Jonathan noticed in code review that I threw away some SO terms that appeared
only in snp125Ui.c in e49078c1, and also suggested using a single mapping table
instead of duplicating the mappings in soTerm.c.  Better now.  refs #17897, #17209
Also corrected a SO term: non_coding_exon_variant --> non_coding_transcript_exon_variant.

diff --git src/hg/lib/gpFx.c src/hg/lib/gpFx.c
index d4e365b..4eab84d 100644
--- src/hg/lib/gpFx.c
+++ src/hg/lib/gpFx.c
@@ -297,32 +297,32 @@
     {
     if (predIsNmd)
 	// This transcript is already subject to nonsense-mediated decay, so the effect
 	// is probably not a big deal:
 	term = NMD_transcript_variant;
     gpFx = gpFxNew(allele->sequence, pred->name, term, nonCodingExon, lm);
     setNCExonVals(gpFx, exonIx, txc->startInCdna);
     }
 return gpFx;
 }
 
 static struct gpFx *gpFxChangedNoncodingExon(struct allele *allele, struct genePred *pred,
 					     struct txCoords *txc, int exonIx, struct lm *lm)
 /* generate an effect for a variant in a non-coding transcript */
 {
-struct gpFx *gpFx = gpFxNew(allele->sequence, pred->name, non_coding_exon_variant, nonCodingExon,
-			    lm);
+struct gpFx *gpFx = gpFxNew(allele->sequence, pred->name, non_coding_transcript_exon_variant,
+                            nonCodingExon, lm);
 setNCExonVals(gpFx, exonIx, txc->startInCdna);
 return gpFx;
 }
 
 static int getCodingOffsetInTx(struct genePred *pred, char strand)
 /* Skip past UTR (portions of) exons to get offset of CDS relative to transcript start.
  * The strand arg is used instead of pred->strand. */
 {
 int offset = 0;
 int iStart = 0, iIncr = 1;
 boolean isRc = (strand == '-');
 if (isRc)
     {
     // Work our way left from the last exon.
     iStart = pred->exonCount - 1;