96f933be7215c92173bbf2dbb8dc1cedbe23b1c1 jcasper Wed Nov 9 11:36:42 2016 -0800 Fixing buffer overflow with bigger buffer, refs #18369 diff --git src/hg/hgTracks/cds.c src/hg/hgTracks/cds.c index 10f8307..7cab435 100644 --- src/hg/hgTracks/cds.c +++ src/hg/hgTracks/cds.c @@ -605,31 +605,31 @@ static void getGenbankCds(char *acc, struct genbankCds* cds) /* Get cds start and stop from genbank tables, if available. Otherwise it * does nothing */ { static boolean first = TRUE, haveGbCdnaInfo = FALSE; struct sqlConnection *conn = hAllocConn(database); if (first) { haveGbCdnaInfo = sqlTableExists(conn, gbCdnaInfoTable); first = FALSE; } if (haveGbCdnaInfo) { - char query[256], buf[256], *cdsStr; + char query[4096], buf[4096], *cdsStr; sqlSafef(query, sizeof query, "select c.name from %s g,%s c where (acc = '%s') and (g.cds = c.id)", gbCdnaInfoTable, cdsTable, acc); cdsStr = sqlQuickQuery(conn, query, buf, sizeof(buf)); if (cdsStr != NULL) genbankCdsParse(cdsStr, cds); } hFreeConn(&conn); } static void getCdsFromTbl(char *acc, char *baseColorSetting, struct genbankCds* cds) /* Get CDS from a specified table, doing nothing if not found */ { char *p = skipToSpaces(baseColorSetting); char *cdsSpecTbl = skipLeadingSpaces(p); if (*cdsSpecTbl == '\0') errAbort("%s table requires a table name as an argument", BASE_COLOR_USE_CDS);