Commits for galt

v345_preview2 to v345_base (2017-02-13 to 2017-02-20) v345

983c57a31c9479ba5fd76f3a732ef44d414d5a7e Mon Feb 13 13:12:27 2017 -0800

• oops reversing accidental conflict resolution mistake.
  • src/hg/lib/jWestBanner.html - lines changed 2, context: html, text, full: html, text

165c47b371042ea8f0c0bbfe3a9fce06b8767344 Mon Feb 13 13:35:12 2017 -0800

• oops puts was supplying newlines. refs #18737.
  • src/hg/cirm/cdw/cdwWebBrowse/cdwWebBrowse.c - lines changed 2, context: html, text, full: html, text

a2fbae6e90d06cb308aa2e050cd8f77c60c6cc96 Mon Feb 13 14:38:47 2017 -0800

• Oops. fixing accidentally messed up indentation. refs #18737
  • src/hg/lib/hui.c - lines changed 68, context: html, text, full: html, text

c185c5bbae11a20d912e82f544dfe6f5ef5818bf Mon Feb 13 15:41:54 2017 -0800

• Giving function better name. CSP changes. Review feedback. refs #18737
  • src/hg/hgTables/filterFields.c - lines changed 2, context: html, text, full: html, text
  • src/hg/lib/cart.c - lines changed 1, context: html, text, full: html, text
  • src/hg/lib/hui.c - lines changed 1, context: html, text, full: html, text
  • src/inc/cheapcgi.h - lines changed 1, context: html, text, full: html, text
  • src/lib/cheapcgi.c - lines changed 1, context: html, text, full: html, text

5c060e59f4dfaaef7d80080266ed0784c7b1aa82 Mon Feb 13 15:55:34 2017 -0800

• using makeRandomKey in cart.c, removed redundant copy in cartDb.c. code review feedback. refs #18737
  • src/hg/lib/cart.c - lines changed 1, context: html, text, full: html, text
  • src/hg/lib/cartDb.c - lines changed 18, context: html, text, full: html, text
  • src/inc/htmshell.h - lines changed 3, context: html, text, full: html, text
  • src/lib/htmshell.c - lines changed 3, context: html, text, full: html, text

c40e54eddbe415b7cc50cd4b828948bf416958ac Mon Feb 13 16:03:32 2017 -0800

• cleanup removing obsolete gtext function.
  • src/hg/hgTracks/gtexTracks.c - lines changed 10, context: html, text, full: html, text

f041be1ae3ccc37baa7b0e8e27780d3cb64557ae Mon Feb 13 16:05:20 2017 -0800

• code cleanup.
  • src/hg/hgTracks/imageV2.c - lines changed 2, context: html, text, full: html, text

df6193cf70930acac4b40670a6b3017b3fd7344e Mon Feb 13 16:06:23 2017 -0800

• code cleanup.
  • src/hg/lib/hui.c - lines changed 1, context: html, text, full: html, text

319b5a2b4da69b9d20be21ce493e2c51c8891d87 Mon Feb 13 16:08:20 2017 -0800

• code cleanup.
  • src/hg/hgcentralTidy/hgcentralTidy.c - lines changed 7, context: html, text, full: html, text

33b95577fc33857345402b4462ce5e094207b24a Mon Feb 13 16:09:21 2017 -0800

• code cleanup.
  • src/hg/lib/jksql.c - lines changed 1, context: html, text, full: html, text

e078d7657a37144198bcc0320d527655e1a60689 Mon Feb 13 16:18:41 2017 -0800

• oops, should have yanked this .h definition. It exists in htmshell.h now instead.
  • src/hg/inc/cartDb.h - lines changed 3, context: html, text, full: html, text

bcbb8d33a61ae54020a12b2b34113a34c933eb29 Tue Feb 14 23:00:00 2017 -0800

• Adding convenience var arg functions jsInlineF and jsOnEventByIdF, suggested by Angie.
  • src/inc/cheapcgi.h - lines changed 14, context: html, text, full: html, text
  • src/inc/dystring.h - lines changed 0, context: html, text, full: html, text (a binary file or whitespace-only change shows no diff)
  • src/lib/cheapcgi.c - lines changed 24, context: html, text, full: html, text

fb54b782482ebcc05df2647776f624ddea8301e4 Wed Feb 15 14:18:02 2017 -0800

• fixes minor javascript syntax issues, missing semi-colon and newline. refs #18538
  • src/hg/hgLogin/hgLogin.c - lines changed 7, context: html, text, full: html, text

313531099a6e334521a493a0fa296b1738ee93a7 Wed Feb 15 15:18:59 2017 -0800

• Trying to make sure that js blocks end with a newline, and often a semi-colon before that. This causes trouble for short fragments of js that used to be able to skate by without it. Now that they are joined into larger blocks of js, the proper puncutation is required. refs #18538
  • src/hg/encode/hgEncodeVocab/hgEncodeVocab.c - lines changed 1, context: html, text, full: html, text
  • src/hg/hgBlat/hgBlat.c - lines changed 2, context: html, text, full: html, text
  • src/hg/hgTables/genomeSpace.c - lines changed 2, context: html, text, full: html, text
  • src/hg/hgTracks/extTools.c - lines changed 1, context: html, text, full: html, text
  • src/hg/lib/fileUi.c - lines changed 2, context: html, text, full: html, text
  • src/hg/lib/hui.c - lines changed 1, context: html, text, full: html, text
  • src/hg/lib/jsHelper.c - lines changed 2, context: html, text, full: html, text
  • src/hg/visiGene/hgVisiGene/hgVisiGene.c - lines changed 2, context: html, text, full: html, text

733819dd56c3d6d3b945236e0c3a06633f6484e3 Wed Feb 15 22:41:29 2017 -0800

• CSP - adding name as id for cgiMakeButton. Adding event parameter to event function so it will be available to functions that need it. refs #18538
  • src/lib/cheapcgi.c - lines changed 8, context: html, text, full: html, text

50b2e5f80ed6f564a694e5909a56f45cfc194dee Thu Feb 16 11:32:29 2017 -0800

• For backwards compatibility with event param in IE. refs #18538
  • src/lib/cheapcgi.c - lines changed 2, context: html, text, full: html, text