a53b9958fa734f73aeffb9ddfe2fbad1ca65f90c
galt
  Mon Jan 30 16:18:41 2017 -0800
Check-in of CSP2 Content-Security-Policy work. All C-language CGIs should now support CSP2 in browser to stop major forms of XSS javascript injection. Javascript on pages is gathered together, and then emitted in a single script block at the end with a nonce that tells the browser, this is js that we generated instead of being injected by a hacker. Both inline script from script blocks and inline js event handlers had to be pulled out and separated. You will not see js sprinkled through-out the page now. Older browsers that support CSP1 or that do not understand CSP at all will still work, just without protection. External js libraries loaded at runtime need to be added to the CSP policy header in src/lib/htmshell.c.

diff --git src/hg/hgApi/hgApi.c src/hg/hgApi/hgApi.c
index c370ab4..43c46ef 100644
--- src/hg/hgApi/hgApi.c
+++ src/hg/hgApi/hgApi.c
@@ -111,52 +111,52 @@
             errAbort("Unsupported 'cmd' parameter");
 
         enum cvSearchable searchBy = cvSearchMethod(var);
         char name[128];
         safef(name,sizeof name,"%s%i",METADATA_VALUE_PREFIX,ix);
         if (searchBy == cvSearchBySingleSelect || searchBy == cvSearchByMultiSelect)
             {
             boolean fileSearch = (cgiOptionalInt("fileSearch",0) == 1);
             struct slPair *pairs = mdbValLabelSearch(conn, var, MDB_VAL_STD_TRUNCATION, FALSE,
                                                      !fileSearch, fileSearch);
             if (slCount(pairs) > 0)
                 {
                 char *dropDownHtml =
                                 cgiMakeSelectDropList((searchBy == cvSearchByMultiSelect),
                                                       name, pairs, NULL, ANYLABEL, "mdbVal",
-                                                      "style='min-width: 200px; font-size: .9em;' "
-                                                      "onchange='findTracksMdbValChanged(this);'");
+                                                      "change", "findTracksMdbValChanged(this);",
+                                                      "min-width: 200px; font-size: .9em;", NULL);
                 if (dropDownHtml)
                     {
                     dyStringAppend(output,dropDownHtml);
                     freeMem(dropDownHtml);
                     }
                 slPairFreeList(&pairs);
                 }
             }
         else if (searchBy == cvSearchByFreeText)
             {
-            dyStringPrintf(output,"<input type='text' name='%s' value='' class='mdbVal freeText' "
-                           "onchange='findTracksMdbValChanged(this);' style='max-width:310px; "
-                           "width:310px; font-size:.9em;'>", name);
+            dyStringPrintf(output,"<input type='text' name='%s' id='%s' value='' class='mdbVal freeText' "
+			   "style='max-width:310px; width:310px; font-size:.9em;'>", name, name);
+	    jsOnEventById("change", name, "findTracksMdbValChanged(this);");
             }
         else if (searchBy == cvSearchByWildList)
             {
-            dyStringPrintf(output,"<input type='text' name='%s' value='' class='mdbVal wildList' "
+            dyStringPrintf(output,"<input type='text' name='%s' id='%s' value='' class='mdbVal wildList' "
                            "title='enter comma separated list of values' "
-                           "onchange='findTracksMdbValChanged(this);' style='max-width:310px; "
-                           "width:310px; font-size:.9em;'>", name);
+			   "style='max-width:310px; width:310px; font-size:.9em;'>", name, name);
+	    jsOnEventById("change", name, "findTracksMdbValChanged(this);");
             }
         else if (searchBy == cvSearchByDateRange || searchBy == cvSearchByIntegerRange)
             {
             // TO BE IMPLEMENTED
             }
         else
             errAbort("Metadata variable not searchable");
 
         dyStringPrintf(output,"<span id='helpLink%i'>&nbsp;</span>",ix);
         }
     else
         errAbort("Assembly does not support metaDb");
     }
 else if (!strcmp(cmd, "tableMetadata"))
     { // returns an html table with metadata for a given track