a53b9958fa734f73aeffb9ddfe2fbad1ca65f90c
galt
  Mon Jan 30 16:18:41 2017 -0800
Check-in of CSP2 Content-Security-Policy work. All C-language CGIs should now support CSP2 in browser to stop major forms of XSS javascript injection. Javascript on pages is gathered together, and then emitted in a single script block at the end with a nonce that tells the browser, this is js that we generated instead of being injected by a hacker. Both inline script from script blocks and inline js event handlers had to be pulled out and separated. You will not see js sprinkled through-out the page now. Older browsers that support CSP1 or that do not understand CSP at all will still work, just without protection. External js libraries loaded at runtime need to be added to the CSP policy header in src/lib/htmshell.c.

diff --git src/hg/hgTracks/cytoBandTrack.c src/hg/hgTracks/cytoBandTrack.c
index 03089d5..d830b81 100644
--- src/hg/hgTracks/cytoBandTrack.c
+++ src/hg/hgTracks/cytoBandTrack.c
@@ -213,31 +213,30 @@
    now that we are done spoofing tgDrawItems(). */
 tg->heightPer += 11;
 tg->lineHeight += 11;
 }
 
 void cytoBandIdeoMapItem(struct track *tg, struct hvGfx *hvg, void *item,
 			    char *itemName, char *mapItemName, int start, int end,
 			    int x, int y, int width, int height)
 /* Print out a box to jump to band in browser window .*/
 {
 struct cytoBand *cb = item;
 
 x = hvGfxAdjXW(hvg, x, width);
 
 hPrintf("<AREA SHAPE=RECT COORDS=\"%d,%d,%d,%d\" ", x, y, x+width, y+height);
-hPrintf("onclick='return false;' ");
 hPrintf("HREF=\"#\" class='cytoBand'");
 mapStatusMessage("%s %s:%d-%d", (cb->name==NULL?"":cb->name),cb->chrom, cb->chromStart+1, cb->chromEnd);
 hPrintf(">\n");
 
 }
 
 int cytoBandIdeoTotalHeight(struct track *tg, enum trackVisibility vis)
 /* Return the (nonstandard) height of the cytoBandIdeo track. */
 {
 tg->heightPer = tl.fontHeight + 11;
 tg->lineHeight = tl.fontHeight + 11;
 tg->limitedVisSet = TRUE;
 if(vis != tvHide && slCount(tg->items) > 0)
     {
     tg->limitedVis = tvDense;