3c556eed91140fc152600a25bdccdc72cf9dc6b4
max
  Mon May 15 12:55:38 2017 -0700
fixing error message 'no value specified for field "settings"' by newer
Mysql versions that do not accept missing fields in INSERT statements,
This is another bug of the type previously fixed in refs #18626

diff --git src/hg/hgSession/hgSession.c src/hg/hgSession/hgSession.c
index 78585ea..2725b89 100644
--- src/hg/hgSession/hgSession.c
+++ src/hg/hgSession/hgSession.c
@@ -757,45 +757,45 @@
 	firstUse = firstUseBuf;
 	useCount = atoi(row[1]) + 1;
 	}
     sqlFreeResult(&sr);
 
     /* Remove pre-existing session (if any) before updating. */
     dyStringClear(dy);
     sqlDyStringPrintf(dy, "DELETE FROM %s WHERE userName = '%s' AND "
 		       "sessionName = '%s';",
 		   namedSessionTable, encUserName, encSessionName);
     sqlUpdate(conn, dy->string);
 
     dyStringClear(dy);
     sqlDyStringPrintf(dy, "INSERT INTO %s ", namedSessionTable);
     dyStringAppend(dy, "(userName, sessionName, contents, shared, "
-		       "firstUse, lastUse, useCount) VALUES (");
+		       "firstUse, lastUse, useCount, settings) VALUES (");
     dyStringPrintf(dy, "'%s', '%s', ", encUserName, encSessionName);
     dyStringAppend(dy, "'");
     cleanHgSessionFromCart(cart);
     struct dyString *encoded = newDyString(4096);
     cartEncodeState(cart, encoded);
 
     // Now add all the default visibilities to output.
     outDefaultTracks(cart, encoded);
 
     sqlDyAppendEscaped(dy, encoded->string);
     dyStringFree(&encoded);
     dyStringAppend(dy, "', ");
     dyStringPrintf(dy, "%d, ", (shareSession ? 1 : 0));
-    dyStringPrintf(dy, "%s, now(), %d);", firstUse, useCount);
+    dyStringPrintf(dy, "%s, now(), %d, '');", firstUse, useCount);
     sqlUpdate(conn, dy->string);
     dyStringFree(&dy);
 
     /* Prevent modification of custom tracks just saved to namedSessionDb: */
     cartCopyCustomTracks(cart);
 
     if (useCount > INITIAL_USE_COUNT)
 	dyStringPrintf(dyMessage,
 	  "Overwrote the contents of session <B>%s</B> "
 	  "(that %s be shared with other users).  "
 	  "%s %s",
 	  htmlEncode(sessionName), (shareSession ? "may" : "may not"),
 	  getSessionLink(encUserName, encSessionName),
 	  getSessionEmailLink(encUserName, encSessionName));
     else