54d8983c10eaff12d0e287b09f6417f7c37bcdf5 angie Tue Oct 16 13:24:24 2018 -0700 Oops, forgot to call normalizeVersion in hgvsToTxCoords to get consistent RefSeq vs. GenBank transcript CDS. 'make test' failure triggered by GenBank update. diff --git src/hg/lib/hgHgvs.c src/hg/lib/hgHgvs.c index 340f406..7ef08da 100644 --- src/hg/lib/hgHgvs.c +++ src/hg/lib/hgHgvs.c @@ -2088,31 +2088,32 @@ } static boolean hgvsToTxCoords(struct hgvsVariant *hgvs, char *db, uint *retStart, uint *retEnd) /* If hgvs is not coding then set *retStart to hgvs->start1-1 and *retEnd to hgvs->end & ret TRUE. * If coding and we have complete CDS info then apply cdsStart and/or cdsEnd offset to start & end. * If start or end is intronic, or start is negative (genomic upstream of tx) then return FALSE. * Note: at this point we don't know the length of the sequence so can't tell if start and/or end * fall past the end of the transcript (genomic downstream). */ { boolean coordsOk = TRUE; int start, end; hgvsStartEndToZeroBasedHalfOpen(hgvs, &start, &end); if (hgvs->type == hgvstCoding) { struct genbankCds cds; - if (getCds(db, hgvs->seqAcc, &cds)) + char *acc = normalizeVersion(db, hgvs->seqAcc, NULL); + if (getCds(db, acc, &cds)) { // Determine whether to use cdsStart or cdsEnd for hgvs start and hgvs end. // Make sure the cds start and end are marked as complete. if (hgvs->startIsUtr3 && cds.endComplete) start += cds.end; else if (!hgvs->startIsUtr3 && cds.startComplete) start += cds.start; else coordsOk = FALSE; if (hgvs->endIsUtr3 && cds.endComplete) end += cds.end; else if (!hgvs->endIsUtr3 && cds.startComplete) end += cds.start; else coordsOk = FALSE;