a9d2eb19d6d3aef4e8a223466f1e0c3afd212973
chmalee
Wed Oct 31 16:29:47 2018 -0700
Fixing barChart hgc buffer overflow bug on sandboxes and genome-test, refs #18508
diff --git src/hg/hgc/barChartClick.c src/hg/hgc/barChartClick.c
index 70b64f7..531a725 100644
--- src/hg/hgc/barChartClick.c
+++ src/hg/hgc/barChartClick.c
@@ -344,31 +344,31 @@
{
//fprintf(f, "%s\t#%06X\n", categ->label, categ->color);
fprintf(f, "%s\t%d\n", categ->label, categ->color);
}
fclose(f);
return cloneString(colorTn.forCgi);
}
static void printBoxplot(char *df, char *item, char *name2, char *units, char *colorFile)
/* Plot data frame to image file and include in HTML */
{
struct tempName pngTn;
trashDirFile(&pngTn, "hgc", "barChart", ".png");
/* Exec R in quiet mode, without reading/saving environment or workspace */
-char cmd[256];
+char cmd[512];
safef(cmd, sizeof(cmd), "Rscript --vanilla --slave hgcData/barChartBoxplot.R %s %s %s %s %s %s",
item, units, colorFile, df, pngTn.forHtml, isEmpty(name2) ? "n/a" : name2);
int ret = system(cmd);
if (ret == 0)
printf("
\n", pngTn.forHtml);
else
warn("Error creating boxplot from sample data");
}
struct asColumn *asFindColByIx(struct asObject *as, int ix)
/* Find AS column by index */
{
struct asColumn *asCol;
int i;
for (i=0, asCol = as->columnList; asCol != NULL && inext, i++);