e81403a315a24af601884b8a19e89bcecc92f267
galt
  Sat Dec 8 20:04:28 2018 -0800
Fixing hFindSplitTable and its use. Standard size, give real string size so no undetected overflows. Test result and abort if not found. Avoids SQL errors that otherwise will popup. Handles uninitialzed stack better for the output name. refs #22596.

diff --git src/hg/featureBits/featureBits.c src/hg/featureBits/featureBits.c
index 3ad30c7..e4ff10d 100644
--- src/hg/featureBits/featureBits.c
+++ src/hg/featureBits/featureBits.c
@@ -442,35 +442,33 @@
 /* Or in table if it exists.  Else do nothing. */
 {
 char t[512], *s;
 char table[HDB_MAX_TABLE_STRING];
 
 isolateTrackPartOfSpec(track, t);
 s = strrchr(t, '.');
 if (s != NULL)
     {
     orFile(acc, track, chrom, chromSize);
     }
 else
     {
     boolean hasBin;
     int minFeatureSize = optionInt("minFeatureSize", 0);
-    boolean isSplit = hFindSplitTable(database, chrom, t, table, &hasBin);
-    boolean isFound = hTableExists(database, table);
-    verbose(3,"orTable: db: %s isFound: %s isSplit: %s %s %s %s\n", database,
-	isFound ? "TRUE" : "FALSE",
-	    isSplit ? "TRUE" : "FALSE", chrom, t, table );
+    boolean isFound = hFindSplitTable(database, chrom, t, table, sizeof table, &hasBin);
+    verbose(3,"orTable: db: %s isFound: %s %s %s %s\n", database,
+	isFound ? "TRUE" : "FALSE", chrom, t, table );
     if (isFound)
 	fbOrTableBitsQueryMinSize(database, acc, track, chrom, chromSize, conn, where,
 		   TRUE, TRUE, minFeatureSize);
     }
 }
 
 
 void chromFeatureBits(struct sqlConnection *conn,char *database, 
 	char *chrom, int tableCount, char *tables[],
 	FILE *bedFile, FILE *faFile, FILE *binFile,
         struct bed *bedRegionList, FILE *bedOutFile,
 	int chromSize, int *retChromBits,
 	int *retFirstTableBits, int *retSecondTableBits)
 /* featureBits - Correlate tables via bitmap projections and booleans
  * on one chromosome. */
@@ -542,32 +540,32 @@
  * This separate routine handles the non-merged case.  It's
  * reason for being is so that the feature names get preserved. */
 {
 boolean hasBin;
 char t[512], *s = NULL;
 char table[HDB_MAX_TABLE_STRING];
 struct featureBits *fbList = NULL, *fb;
 
 if (trackSpec[0] == '!')
    errAbort("Sorry, '!' not available with fa output unless you use faMerge");
 isolateTrackPartOfSpec(trackSpec, t);
 s = strchr(t, '.');
 if (s != NULL)
     errAbort("Sorry, only database (not file) tracks allowed with "
              "fa output unless you use faMerge");
-// ignore isSplit return from hFindSplitTable()
-(void) hFindSplitTable(database, chrom, t, table, &hasBin);
+if (!hFindSplitTable(database, chrom, t, table, sizeof table, &hasBin))
+    errAbort("track %s not found", t);
 fbList = fbGetRangeQuery(database, trackSpec, chrom, 0, hChromSize(database, chrom),
 			 where, TRUE, TRUE);
 for (fb = fbList; fb != NULL; fb = fb->next)
     {
     int s = fb->start, e = fb->end;
     if (bedFile != NULL)
 	{
 	fprintf(bedFile, "%s\t%d\t%d\t%s", 
 	    fb->chrom, fb->start, fb->end, fb->name);
 	if (fb->strand != '?')
 	    fprintf(bedFile, "\t0\t%c", fb->strand);
 	fprintf(bedFile, "\n");
 	}
     if (faFile != NULL)
         {
@@ -741,31 +739,31 @@
 	{
 	if (inclChrom(cInfo->chrom))
 	    {
 	    if (s)
 		{
 		chromFileName(t, cInfo->chrom, fileName);
 		if (fileExists(fileName))
 		    {
 		    found = TRUE;
 		    break;
 		    }
 		}
 	    else
 		{
 		boolean hasBin;
-		if (hFindSplitTable(database, cInfo->chrom, t, table, &hasBin))
+		if (hFindSplitTable(database, cInfo->chrom, t, table, sizeof table, &hasBin))
 		    {
 		    found = TRUE;
 		    break;
 		    }
 		}
 	    }
 	}
     if (!found)
 	{
 	if (s)
 	    warn("file %s not found for any chroms", t);
 	else
 	    warn("table %s not found for any chroms", t);
 	++missing;	    
 	}