e81403a315a24af601884b8a19e89bcecc92f267
galt
  Sat Dec 8 20:04:28 2018 -0800
Fixing hFindSplitTable and its use. Standard size, give real string size so no undetected overflows. Test result and abort if not found. Avoids SQL errors that otherwise will popup. Handles uninitialzed stack better for the output name. refs #22596.

diff --git src/hg/hgc/lowelab.c src/hg/hgc/lowelab.c
index b503203..8f918b4 100644
--- src/hg/hgc/lowelab.c
+++ src/hg/hgc/lowelab.c
@@ -466,31 +466,31 @@
 int wordCount, x, length;
 int num = 0;
 int hits = 0;
 struct sqlConnection *conn = hAllocConn(database);
 struct sqlConnection *conn2;
 struct sqlConnection *spConn = NULL;
 struct COG *COG=NULL;
 struct COGXra *COGXra=NULL;
 char *temparray[160];
 char *giwords[5];
 char *spAcc = NULL;
 struct slName *el, *list;
 char *table = tdb->table;
 char *pdb = hPdbFromGdb(database);
 struct genePred *gpList = NULL, *gp = NULL;
-char tableName[64];
+char tableName[HDB_MAX_TABLE_STRING];
 boolean hasBin;
 int itemCount = 0;
 int arcogCount = 0;
 char genome[50] = "";
 char clade[50] = "";
 boolean hasArCOG;
 
 char treeFileName[256];
 char treeTmpPsFileName[256];
 char treePsFileName[256];
 char treePngFileName[256];
 char treePdfFileName[256];
 char command[512];
 char buffer[512];
 char searchTerm[256];
@@ -568,31 +568,32 @@
 printf("<br><hr style='width:100%%; height:2px;'><span style='font-size:larger;'>\n");
 printf("<b>[<a href=\"#positions\">Positions and Sequence</a>]&nbsp;&nbsp;&nbsp;\n");
 printf("[<a href=\"#COG\">COG</a>]&nbsp;&nbsp;&nbsp;\n");
 printf("[<a href=\"#GO\">Gene Ontology</a>]&nbsp;&nbsp;&nbsp;\n");
 printf("[<a href=\"#domain\">Protein Domain and Structure Infomation</a>]&nbsp;&nbsp;&nbsp;\n");
 printf("[<a href=\"#homology\">Gene Homology</a>]&nbsp;&nbsp;&nbsp;\n");
 printf("[<a href=\"#pathway\">Pathway</a>]</b></span> <br>\n");
 printf("<hr style=\"width: 100%%; height: 2px;\"><br>\n");
 
 /* Positions and sequence */
 printf("<table style=\"text-align: left; width: 99%%;\" border=\"1\" cellpadding=\"5\" cellspacing=\"0\">\n");
 printf("<tbody><tr><td style=\"background-color:#eee9e9;\">\n");
 printf("<a name=\"positions\"></a><b>Positions and Sequence</b><br></td></tr>\n");
 printf("<tr><td>\n");
 
-hFindSplitTable(database, seqName, table, tableName, &hasBin);
+if (!hFindSplitTable(database, seqName, table, tableName, sizeof tableName, &hasBin))
+    errAbort("track %s not found", table);
 sqlSafefFrag(query, sizeof(query), "name = \"%s\"", item);
 gpList = genePredReaderLoadQuery(conn, tableName, query);
 for (gp = gpList; gp != NULL; gp = gp->next)
 {
     sequence = hDnaFromSeq(database, gp->chrom, gp->txStart, gp->txEnd, dnaUpper);
     if (sequence != NULL)
         printf("<B>GC content:</B> %0.2f%%<BR>\n", computeGCContent(sequence->dna, sequence->size));
 }
 geneShowPosAndLinks(item, item, tdb, pepTableName, "htcTranslatedProtein",
             "htcGeneMrna", "htcGeneInGenome", "Predicted mRNA");
 genePredFreeList(&gpList);
 
 printf("</td></tr></tbody></table><br>\n");
 
 /* COG */