File Changes for angie
switch to commits view, user indexv388_preview to v388_preview2 (2019-09-09 to 2019-09-16) v388
Show details
- src/hg/hgSession/hgSession.c
- lines changed 6, context: html, text, full: html, text
cd8473cd35938a2831c33c2885434cccadcf0376 Tue Sep 10 11:57:53 2019 -0700
When re-saving a session, don't delete the session from namedSessionDb until & unless saveSessionData has completed without errAbort. By deleting before saveSessionData, we were losing sessions when there was an errAbort condition. refs #24119
- lines changed 1, context: html, text, full: html, text
6768497aef1c95abb9b086299377cd09a9bc6c72 Wed Sep 11 11:23:14 2019 -0700
Specifically for re-saving an existing session (to convert from trash/customTrash to userdata/customData*), don't trimSpaces from the sessionName, in order to support old sessions with encoded spaces at the beginning or end of sessionName.
- lines changed 1, context: html, text, full: html, text
74712c66fa53216d421fb68e6b643d3f2182271a Wed Sep 11 13:37:46 2019 -0700
Strip leading/trailing spaces from session name when changing session name, not only when saving a session the usual way. refs #24124
- lines changed 88, context: html, text, full: html, text
a8787479d4851e364fa680e19d68fe5743b096be Thu Sep 12 13:10:19 2019 -0700
When changing session name, detect if the new name would overwrite an existing session and confirm with user. Then allow overwrite if confirmed. refs #24133
- lines changed 6, context: html, text, full: html, text
c8df7c4f49ddb9af903603586ad4238159318942 Fri Sep 13 10:41:26 2019 -0700
The session details 'use' button also has the effect of accepting changes (ugh), so check if a name change means overwriting an existing session there too. refs #24133
- lines changed 10, context: html, text, full: html, text
fb59b3cbfd52ccb31b7691e1718a23fdad4c9e9f Fri Sep 13 11:16:17 2019 -0700
Removed the redundant and troublesome 'use' and 'delete' buttons from the session details change form. refs #24133
- src/hg/hgSession/sessionData.c
- lines changed 7, context: html, text, full: html, text
d068d2fb67acf09e2b8b333a32c099da418a8df9 Tue Sep 10 14:12:30 2019 -0700
When re-saving a session, if userdata ctfile already exists, just recreate it instead of errAborting; otherwise, the session can never be saved after an initial timeout or other problem. refs #24121.
- lines changed 3, context: html, text, full: html, text
196f6933bbd781e74d3d63203b7d6d4ad3ad6eac Tue Sep 10 14:39:42 2019 -0700
Add NULL check in case a customTrash wiggle table has no rows. I haven't found a way to recreate an empty wiggle table with the CGIs, only manually, but there was one case of this in the >100,000 old sessions on the RR.
switch to commits view, user index