8bbc807db3bfb9774c93264c0167ac129239b624
hiram
  Wed Jan 29 11:32:51 2020 -0800
not all NCBI fields may be defined refs #24851

diff --git src/hg/utils/automation/makeGenomeDb.pl src/hg/utils/automation/makeGenomeDb.pl
index c3011d9..33378ac 100755
--- src/hg/utils/automation/makeGenomeDb.pl
+++ src/hg/utils/automation/makeGenomeDb.pl
@@ -1031,38 +1031,49 @@
   <TR><TD ALIGN=RIGHT>
     <FONT SIZE=-1><em>$scientificName</em><BR>
     </FONT>
     <FONT SIZE=-2>
       (<A HREF="$photoCreditURL"
       TARGET=_blank>$photoCreditName</A>)
     </FONT>
   </TD></TR>
 </TABLE>
 
 <P>
 <B>UCSC Genome Browser assembly ID:</B> $db<BR>
 <B>Sequencing/Assembly provider ID:</B> $assemblyLabel $providerAssemblyName<BR>
 <B>Assembly date:</B> $assemblyDate<BR>
 <B>Accession ID:</B> $genBankAccessionID<BR>
-<B>NCBI Genome ID:</B> <A HREF="https://www.ncbi.nlm.nih.gov/genome/$ncbiGenomeId"
-TARGET="_blank">$ncbiGenomeId</A> ($scientificName)<BR>
-<B>NCBI Assembly ID:</B> <A HREF="https://www.ncbi.nlm.nih.gov/assembly/$ncbiAssemblyId"
-TARGET="_blank">$ncbiAssemblyId</A><BR>
-<B>NCBI BioProject ID:</B> <A HREF="https://www.ncbi.nlm.nih.gov/bioproject/$ncbiBioProject"
-TARGET="_blank">$ncbiBioProject</A><BR>
-<B>NCBI BioSample ID:</B> <A HREF="https://www.ncbi.nlm.nih.gov/biosample/$ncbiBioSample"
-TARGET="_blank">$ncbiBioSample</A>
+_EOF_
+  ;
+  if ($ncbiGenomeId ne "n/a") {
+  printf $fh "<B>NCBI Genome ID:</B> <A HREF='https://www.ncbi.nlm.nih.gov/genome/$ncbiGenomeId'
+TARGET='_blank'>$ncbiGenomeId</A> ($scientificName)<BR>\n";
+  } else {
+  printf $fh "<B>NCBI Genome ID:</B> $ncbiGenomeId<BR>\n";
+  }
+  printf $fh "<B>NCBI Assembly ID:</B> <A HREF='https://www.ncbi.nlm.nih.gov/assembly/$ncbiAssemblyId'
+TARGET='_blank'>$ncbiAssemblyId</A><BR>
+<B>NCBI BioProject ID:</B> <A HREF='https://www.ncbi.nlm.nih.gov/bioproject/$ncbiBioProject'
+TARGET='_blank'>$ncbiBioProject</A><BR>\n";
+  if ($ncbiBioSample ne "n/a") {
+    printf $fh "<B>NCBI BioSample ID:</B> <A HREF='https://www.ncbi.nlm.nih.gov/biosample/$ncbiBioSample'
+TARGET='_blank'>$ncbiBioSample</A>\n";
+  } else {
+    printf $fh "<B>NCBI BioSample ID:</B> $ncbiBioSample<BR>\n";
+  }
+  print $fh <<_EOF_
 </P>
 <HR>
 <P>
 <B>Search the assembly:</B>
 <UL>
 <LI>
 <B>By position or search term: </B> Use the &quot;position or search term&quot;
 box to find areas of the genome associated with many different attributes, such
 as a specific chromosomal coordinate range; mRNA, EST, or STS marker names; or
 keywords from the GenBank description of an mRNA.
 <A HREF="../goldenPath/help/query.html">More information</A>, including sample
 queries.
 <LI>
 <B>By gene name: </B> Type a gene name into the &quot;search term&quot; box,
 choose your gene from the drop-down list, then press &quot;submit&quot; to go