cc25d2f93765ed4a50551dda4e4db9bdff953df5 braney Mon Apr 6 15:46:45 2020 -0700 simplification in response to code review #25308 diff --git src/hg/lib/hdb.c src/hg/lib/hdb.c index 4947a09..1a526ed 100644 --- src/hg/lib/hdb.c +++ src/hg/lib/hdb.c @@ -3884,39 +3884,31 @@ /* Return TRUE if underlying data are accessible - meaning the track has either * a bigDataUrl with remote URL (http:// etc), a bigDataUrl with an existing local file, * or a database table with the same name. * Note: this returns FALSE for composite tracks; use this on subtracks or simple tracks. */ { if (startsWith("mathWig", tdb->type)) return TRUE; // assume mathWig data is available. Fail at load time if it isn't char *bigDataUrl = trackDbSetting(tdb, "bigDataUrl"); if (bigDataUrl != NULL) { bigDataUrl = replaceChars(bigDataUrl, "$D", database); char *bigDataUrlLocal = hReplaceGbdb(bigDataUrl); if (hasProtocol(bigDataUrlLocal)) return TRUE; else - { - boolean exists; - if (hasProtocol(bigDataUrlLocal)) - exists = udcExists(bigDataUrlLocal); - else - exists = fileExists(bigDataUrlLocal); - freeMem(bigDataUrlLocal); - return exists; - } + return fileExists(bigDataUrlLocal); } else { // we now allow references to native tracks in track hubs tdb->table = trackHubSkipHubName(tdb->table); // if it's copied from a custom track, wait to find data later if (isCustomTrack(tdb->table)) return TRUE; return (hTableForTrack(database, tdb->table) != NULL); } } static void addTrackIfDataAccessible(char *database, struct trackDb *tdb, boolean privateHost, struct trackDb **tdbRetList)