dacec81196967c10d494c7b77a49cc41a5aa63ce
kent
Thu Jan 28 22:10:56 2021 -0800
Making a couple of more variables use the varPrefix rather than be hard coded.
diff --git src/hg/lib/tablesTables.c src/hg/lib/tablesTables.c
index 47a37c2..93bf7f0 100644
--- src/hg/lib/tablesTables.c
+++ src/hg/lib/tablesTables.c
@@ -455,36 +455,36 @@
struct facetVal *valListCopy = facetsClone(field->valList);
slSort(&valListCopy, facetValCmp);
for (val = valListCopy; val; val=val->next)
{
boolean specificallySelected = (val->selected && !field->allSelected);
if (specificallySelected)
{
char *op = "remove";
htmlDyStringPrintf(facetBar, "
\n");
htmlDyStringPrintf(facetBar, " ",
specificallySelected ? "true" : "false",
specificallySelected ? "checked" : "");
htmlDyStringPrintf(facetBar, "",
returnUrl, varPrefix,
- op, field->fieldName, val->val, varPrefix
+ op, varPrefix, field->fieldName, varPrefix, val->val, varPrefix
);
htmlDyStringPrintf(facetBar, "%s (%d) ", val->val, val->selectCount);
htmlDyStringPrintf(facetBar, " \n");
}
}
slFreeList(&valListCopy);
htmlDyStringPrintf(facetBar, "\n");
}
}
if (!isEmpty(where) || gotSelected)
{
@@ -504,35 +504,35 @@
"$('[name=%s_page]').val('1');\n"
"$('[name=clearRestriction]').val('1');\n"
"$('#submit').click();\n", varPrefix);
jsOnEventById("click", "clearRestrictionButton", jsText);
printf(" ");
}
if (gotSelected)
{
// reset all facet value selections button
char *op = "resetAll";
htmlPrintf("%s \n",
- returnUrl, varPrefix, op, "", "", varPrefix, "Clear All"
+ returnUrl, varPrefix, op, varPrefix, "", varPrefix, "", varPrefix, "Clear All"
);
printf("\n");
printf("%s\n", facetBar->string);
printf(" \n");
}
if (!isEmpty(where) || gotSelected)
printf(" \n");
dyStringFree(&facetBar);
}
printf("\n"); // parent container
@@ -545,103 +545,104 @@
struct slName *visList = slNameListFromComma(visibleFacetList);
struct slName *vis;
for (vis = visList; vis != NULL; vis = vis->next)
{
int f = fieldedTableMustFindFieldIx(table, vis->name);
struct facetField *field = ffArray[f];
htmlPrintf("
\n");
htmlPrintf("
%s \n", field->fieldName);
struct facetVal *val;
if (!field->allSelected) // add reset facet link
{
char *op = "reset";
htmlPrintf("%s \n",
- returnUrl, varPrefix,
- op, field->fieldName, "", varPrefix,
+ returnUrl, varPrefix, op,
+ varPrefix, field->fieldName, varPrefix, "", varPrefix,
"Clear"
);
}
int valuesShown = 0;
int valuesNotShown = 0;
if (field->showAllValues) // Sort alphabetically if they want all values
{
slSort(&field->valList, facetValCmp);
}
for (val = field->valList; val; val=val->next)
{
boolean specificallySelected = (val->selected && !field->allSelected);
if ((val->selectCount > 0 && (field->showAllValues || valuesShown < facetUsualSize))
|| specificallySelected)
{
++valuesShown;
char *op = "add";
if (specificallySelected)
op = "remove";
printf("\n");
htmlPrintf(" ",
specificallySelected ? "true" : "false",
specificallySelected ? "checked" : "");
htmlPrintf("",
returnUrl, varPrefix,
- op, field->fieldName, val->val, varPrefix
+ op, varPrefix, field->fieldName, varPrefix, val->val, varPrefix
);
htmlPrintf("%s (%d) ", val->val, val->selectCount);
printf(" \n");
}
else if (val->selectCount > 0)
{
++valuesNotShown;
}
}
// show "See More" link when facet has lots of values
if (valuesNotShown > 0)
{
char *op = "showAllValues";
htmlPrintf("See %d More \n",
- returnUrl, varPrefix, op, field->fieldName, "", varPrefix, valuesNotShown
+ returnUrl, varPrefix, op,
+ varPrefix, field->fieldName, varPrefix, "", varPrefix, valuesNotShown
);
}
// show "See Fewer" link when facet has lots of values
if (field->showAllValues && valuesShown >= facetUsualSize)
{
char *op = "showSomeValues";
htmlPrintf("%s \n",
- returnUrl, varPrefix, op, field->fieldName, "", varPrefix,
+ returnUrl, varPrefix, op, varPrefix, field->fieldName, varPrefix, "", varPrefix,
"See Fewer"
);
}
htmlPrintf(" \n");
}
printf("
\n");
// Clicking a checkbox is actually a click on the following link
jsInlineF(
"$(function () {\n"
" $('.cdwFSCheckBox').click(function() {\n"
" this.nextSibling.nextSibling.click();\n"
" });\n"
"});\n");
}