b85c7945f14c858bdd855fbdf2c5a55361052f28 braney Thu Jul 8 13:10:16 2021 -0700 fix up misleading comment diff --git src/hg/lib/hubConnect.c src/hg/lib/hubConnect.c index 67e2bff..1791171 100644 --- src/hg/lib/hubConnect.c +++ src/hg/lib/hubConnect.c @@ -429,31 +429,31 @@ } *pCount = dbCount; return dy->string; } static void insertHubUrlInStatus(char *url) /* add a url to the hubStatus table */ { struct sqlConnection *conn = hConnectCentral(); char query[4096]; char *statusTable = getHubStatusTableName(); sqlGetLockWithTimeout(conn, "central_hubStatus", 15); -// Try to grab a row right before we lock +// Try to grab a row right before we insert but after the lock. sqlSafef(query, sizeof(query), "select id from %s where hubUrl = \"%s\"", statusTable, url); struct sqlResult *sr = sqlGetResult(conn, query); if (sqlNextRow(sr) == NULL) // if we got something from this query, someone added it right before we locked it { if (sqlFieldIndex(conn, statusTable, "firstAdded") >= 0) sqlSafef(query, sizeof(query), "insert into %s (hubUrl,shortLabel,longLabel,dbCount,dbList,status,lastOkTime,lastNotOkTime,errorMessage,firstAdded) values (\"%s\",\"\",\"\",0,NULL,0,\"\",\"\",\"\",now())", statusTable, url); else sqlSafef(query, sizeof(query), "insert into %s (hubUrl) values (\"%s\")", statusTable, url); sqlUpdate(conn, query); } sqlFreeResult(&sr); sqlReleaseLock(conn, "central_hubStatus"); hDisconnectCentral(&conn);