44ccfacbe3a3d4b300f80d48651c77837a4b571e
galt
  Tue Apr 26 11:12:02 2022 -0700
SQL INJECTION Prevention Version 2 - this improves our methods by making subclauses of SQL that get passed around be both easy and correct to use. The way that was achieved was by getting rid of the obscure and not well used functions sqlSafefFrag and sqlDyStringPrintfFrag and replacing them with the plain versions of those functions, since these are not needed anymore. The new version checks for NOSQLINJ in unquoted %-s which is used to include SQL clauses, and will give an error the NOSQLINJ clause is not present, and this will automatically require the correct behavior by developers. sqlDyStringPrint is a very useful function, however because it was not enforced, users could use various other dyString functions and they operated without any awareness or checking for SQL correct use. Now those dyString functions are prohibited and it will produce an error if you try to use a dyString function on a SQL string, which is simply detected by the presence of the NOSQLINJ prefix.

diff --git src/hg/oneShot/cartSimNoInsert/cartSimNoInsert.c src/hg/oneShot/cartSimNoInsert/cartSimNoInsert.c
index 7db5112..cd586a2 100644
--- src/hg/oneShot/cartSimNoInsert/cartSimNoInsert.c
+++ src/hg/oneShot/cartSimNoInsert/cartSimNoInsert.c
@@ -56,32 +56,35 @@
     }
 sqlFreeResult(&sr);
 return result;
 }
 
 void cartSimNoInsert(char *host, char *user, char *password, char *database, char *milliDelayString,
 	char *iterationString)
 /* cartSimNoInsert - simulates N users accessing cart at regular intervals
  * where cart data is read and then written back unchanged */
 {
 int milliDelay = sqlUnsigned(milliDelayString);
 int iterations = sqlUnsigned(iterationString);
 
 /* Figure out size of tables. */
 struct sqlConnection *conn = sqlConnectRemote(host, user, password, database);
-int userDbSize = sqlQuickNum(conn, NOSQLINJ "select count(*) from userDb");
-int sessionDbSize = sqlQuickNum(conn, NOSQLINJ "select count(*) from sessionDb");
+char query2[1024];
+sqlSafef(query2, sizeof query2, "select count(*) from userDb");
+int userDbSize = sqlQuickNum(conn, query2);
+sqlSafef(query2, sizeof query2, "select count(*) from sessionDb");
+int sessionDbSize = sqlQuickNum(conn, query2);
 int sampleSize = min(userDbSize, sessionDbSize);
 int maxSampleSize = 8*1024;
 sampleSize = min(sampleSize, maxSampleSize);
 verbose(2, "# userDb has %d rows,  sessionDb has %d rows, sampling %d\n"
 	, userDbSize, sessionDbSize, sampleSize);
 
 /* Get sample of user id's. */
 int *userIds = getSomeInts(conn, "userDb", "id", sampleSize);
 int *sessionIds = getSomeInts(conn, "sessionDb", "id", sampleSize);
 
 /* Get userCount random indexes. */
 int *randomIxArray, ix;
 AllocArray(randomIxArray, userCount);
 verbose(2, "random user ix:\n");
 for (ix=0; ix<userCount; ++ix)